Skip to content

Commit 53efca7

Browse files
committed
Correct two comments in the Choria transport
The provided_features comment said the list drives task selection, but select_implementation overrides the Base method that reads it; the list serves apply_prep. The context parameter of poll_with_retries also names the poll failure error now, not only log lines. Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com> Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
1 parent 7a838cd commit 53efca7

2 files changed

Lines changed: 4 additions & 5 deletions

File tree

‎lib/bolt/transport/choria.rb‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,9 @@ def initialize
4545
@default_collective = nil
4646
end
4747

48-
# Advertise both shell and powershell so tasks with either requirement
49-
# can be selected. The per-target selection happens in
50-
# select_implementation below, which picks the right feature set based
51-
# on the target's detected OS.
48+
# Task selection does not use this list, since select_implementation
49+
# below overrides the Base method that reads it. The list is kept for
50+
# apply_prep, which reads a transport's provided features.
5251
def provided_features
5352
%w[shell powershell]
5453
end

‎lib/bolt/transport/choria/helpers.rb‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def target_count(targets)
2626
#
2727
# @param targets [Array, Hash] Initial targets to poll (duped internally)
2828
# @param timeout [Numeric] Maximum seconds before exiting
29-
# @param context [String] Label for log messages
29+
# @param context [String] Label for log and error messages
3030
# @return [Hash] with keys:
3131
# - :completed [Hash{Target => Hash}] All finished target outputs, plus a poll
3232
# error for each pending target after RPC_FAILURE_RETRIES failed polls in a row

0 commit comments

Comments
 (0)