Merge pull request #2766 from ViewComponent/joelhawksley-temporary-module-names

Skip temporarily named modules when computing cache digests

Author: joelhawksley

docs/CHANGELOG.md

@@ -10,6 +10,10 @@ nav_order: 6
 
 ## main
 
+* Avoid `NameError` during eager loading when components include modules with temporary names.
+
+    *Joel Hawksley*
+
 * Avoid repeated scanning of unterminated ERB tags during cache dependency discovery.
 
     *Joel Hawksley*

lib/view_component/cache_digest/resolver.rb

@@ -145,7 +145,11 @@ def module_files(component)
         component.ancestors.take_while { |ancestor| ancestor != ViewComponent::Base }.filter_map { |ancestor|
           next if ancestor.is_a?(Class) || ancestor.name.nil?
 
-          path, _line = Object.const_source_location(ancestor.name)
+          begin
+            path, _line = Object.const_source_location(ancestor.name)
+          rescue NameError
+            next
+          end
           path unless path.nil? || path.start_with?(VIEW_COMPONENT_LIB)
         }.uniq
       end

test/sandbox/test/cacheable_test.rb

@@ -447,6 +447,21 @@ def test_cache_digest_changes_when_a_component_an_included_module_renders_change
     ) { CacheableHelperComponent.cache_digest }
   end
 
+  def test_modules_with_temporary_names_are_not_digested
+    skip "Module#set_temporary_name requires Ruby 3.3+" unless Module.method_defined?(:set_temporary_name)
+
+    component = CacheableHelperComponent.dup
+    resolver = ViewComponent::CacheDigest::Resolver.instance
+    source = resolver.source_for(component)
+    mod = Module.new
+    component.include(mod)
+
+    ["ViewComponent::Properties(Extension)", "MissingNamespace::Properties(Extension)"].each do |name|
+      mod.set_temporary_name(name)
+      assert_equal source, resolver.source_for(component)
+    end
+  end
+
   # Every component includes modules from ViewComponent itself, which would
   # otherwise tie every digest to the installed version of the gem.
   def test_modules_view_component_includes_are_not_digested