Skip to content

Commit 5fe7286

Browse files
committed
use callAsyncBlocking() inistead of waitforElement as per request
1 parent c0c708e commit 5fe7286

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

‎resources/benchmark-runner.mjs‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ class Page {
114114
}, 0);
115115
}
116116

117+
async callAsyncBlocking(functionName, ...args) {
118+
return this._frame.contentWindow[functionName](...args);
119+
}
120+
117121
callToGetElement(functionName) {
118122
return this._wrapElement(this._frame.contentWindow[functionName]());
119123
}

‎suites-experimental/media-performance/conferencing.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -336,6 +336,8 @@
336336
}
337337
}
338338

339+
window.runVideoBenchmark = runVideoBenchmark;
340+
window.runVoiceBenchmark = runVoiceBenchmark;
339341
document.getElementById("video-benchmark").addEventListener("click", runVideoBenchmark);
340342
document.getElementById("voice-benchmark").addEventListener("click", runVoiceBenchmark);
341343
})();

‎suites-experimental/media-performance/streaming.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,8 @@
177177
}
178178

179179
window.prefetchVideo = prefetchVideo;
180+
window.initialPlayback = initialPlayback;
181+
window.seek = seek;
180182
document.getElementById("initial-playback").addEventListener("click", initialPlayback);
181183
document.getElementById("seek").addEventListener("click", seek);
182184
})();

‎suites-experimental/suites.mjs‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -302,12 +302,10 @@ export const ExperimentalSuites = freezeSuites([
302302
},
303303
tests: [
304304
new BenchmarkTestStep("VideoChat", async (page) => {
305-
page.querySelector("#video-benchmark").click();
306-
await page.waitForElement("#video-benchmark.completed");
305+
await page.callAsyncBlocking("runVideoBenchmark");
307306
}),
308307
new BenchmarkTestStep("VoiceChat", async (page) => {
309-
page.querySelector("#voice-benchmark").click();
310-
await page.waitForElement("#voice-benchmark.completed");
308+
await page.callAsyncBlocking("runVoiceBenchmark");
311309
}),
312310
],
313311
},
@@ -323,12 +321,10 @@ export const ExperimentalSuites = freezeSuites([
323321
},
324322
tests: [
325323
new BenchmarkTestStep("InitialPlayback", async (page) => {
326-
page.querySelector("#initial-playback").click();
327-
await page.waitForElement("#initial-playback.completed");
324+
await page.callAsyncBlocking("initialPlayback");
328325
}),
329326
new BenchmarkTestStep("Seek", async (page) => {
330-
page.querySelector("#seek").click();
331-
await page.waitForElement("#seek.completed");
327+
await page.callAsyncBlocking("seek");
332328
}),
333329
],
334330
},

0 commit comments

Comments
 (0)