Repository navigation
Conversation
IsUtf8WhiteSpaceCharThis branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40420
Summary
htmlparser::kWhitespaceTableis declared asstd::array<std::array<uint8_t, 255>, 10>, butStrings::IsUtf8WhiteSpaceCharindexes it with a full byte:cranges over 0..255, so when the DFA is in one of the multi-byte UTF-8 states and the next byte is0xff, the lookup uses column 255, one byte past the end of the 255-column row. AddressSanitizer reports this as a global-buffer-overflow.Fix
Widen each row to 256 entries so every possible byte value has a table entry. The additional column is value-initialized to
0(not whitespace), so the existing 0..254 behavior is unchanged.Verification
Before the fix, the reported reproducer aborts with:
After the fix, the same reproducer runs cleanly with no sanitizer report.