You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There is a base class
org.apache.hadoop.hdds.scm.node.states.Node2ObjectsMapforNode2PipelineMapandNode2ContainerMap.It is redundant because of:
Node2ContainerMapis used only in testsNode2PipelineMapdoesn't need inheritance at allMoreover
Node2PipelineMapcontainsConcurrentHashMap<UUID, Set<PipelineID>>and 2synchronizedmethods:void addPipeline(Pipeline pipeline)-> compute if absent for concurrent hash mapvoid removePipeline(Pipeline pipeline)-> compute if present for concurrent hash mapI suppose
synchronizedis redundant here for these two methods.There is a proposed change:
org.apache.hadoop.hdds.scm.node.states.Node2ObjectsMapclassNode2ContainerMapto testssynchronizedforNode2PipelineMap::addPipelineandNode2PipelineMap::removePipelineAll reactions