Repository navigation
Commit 9799b26
authored
[ZEPPELIN-6762] Fix truncated output alerts in the new UI
### What is this PR for?
Fix the unstyled “Output is truncated” alert and its non-functional close button in the new UI.
The alert HTML generated by the server relies on Bootstrap styles and dismissal behavior, which the new UI does not provide. This PR adds light/dark theme styling and close-button handling for both Angular and React.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6762
### How should this be tested?
Automated tests
- Run the following commands from the repository root:
```bash
cd zeppelin-web-angular
npm run test:shell -- src/app/pages/workspace/share/result/result.component.spec.ts --maxWorkers=1
npm --prefix projects/zeppelin-react test -- src/components/renderers/HTMLRenderer.spec.tsx --maxWorkers=1
```
Manual verification
1. Create a notebook using the sh interpreter and run:
```sh
%sh
for i in $(seq 1 20000); do echo "line_$i"; done
```
2. Verify that the “Output is truncated” alert below the output has a background, border, and close button.
3. Click × and verify that only the alert disappears; the output text should remain.
4. Run the paragraph again. Verify that the alert reappears and can also be dismissed by focusing its close button and pressing Enter.
5. Repeat in both light and dark themes.
6. Open the same paragraph in the React Published view and repeat:
```text
/#/notebook/<noteId>/paragraph/<paragraphId>?react=true
```
To verify the row-limit alert with a PostgreSQL JDBC interpreter, set zeppelin.jdbc.maxResult to 1000 and run:
```sql
%jdbc
SELECT generate_series(1, 2000);
```
Verify that the row-limit alert following the table is styled correctly and can be dismissed.
### Screenshots (if appropriate)
**Angular dark theme**
<img width="1280" height="420" alt="zeppelin-6762-angular-dark" src="https://github.com/user-attachments/assets/22343a9e-9aa1-47d8-86a6-6320b3f1d675" />
**Angular light theme**
<img width="1280" height="420" alt="zeppelin-6762-angular-light" src="https://github.com/user-attachments/assets/3498ac84-d76f-4ffe-a831-12d9c7e6e5e6" />
**React dark theme**
<img width="1600" height="525" alt="zeppelin-6762-react-dark" src="https://github.com/user-attachments/assets/d7f85139-e1bf-425e-b189-ffba5de510c5" />
**React light theme**
<img width="1280" height="420" alt="zeppelin-6762-react-light" src="https://github.com/user-attachments/assets/243408ef-3ae0-411f-83e0-5839d123deff" />
### Questions:
* Does the license files need to update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.
Closes #5591 from miinhho/ZEPPELIN-6762-truncated-output-alert.
Signed-off-by: YONGJAE LEE <dev.yongjaelee@gmail.com>1 parent 2d14bb9 commit 9799b26
7 files changed
Lines changed: 123 additions & 1 deletion
File tree
- zeppelin-web-angular
- projects/zeppelin-react/src/components/renderers
- src
- styles
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
79 | 97 | | |
80 | 98 | | |
81 | 99 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
31 | 39 | | |
32 | 40 | | |
33 | 41 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
| 98 | + | |
98 | 99 | | |
99 | 100 | | |
100 | 101 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
363 | 363 | | |
364 | 364 | | |
365 | 365 | | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
| 381 | + | |
| 382 | + | |
| 383 | + | |
| 384 | + | |
| 385 | + | |
| 386 | + | |
| 387 | + | |
| 388 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
326 | 326 | | |
327 | 327 | | |
328 | 328 | | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
329 | 343 | | |
330 | 344 | | |
331 | 345 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
0 commit comments