Fix escapes hidden by dmd nested function / lambda holes (#11122)

Author: dkorpel

std/datetime/systime.d

@@ -10447,13 +10447,13 @@ if (isRandomAccessRange!R && hasSlicing!R && hasLength!R &&
     import std.traits : EnumMembers, isArray;
     import std.typecons : Rebindable;
 
-    void stripAndCheckLen(R valueBefore, size_t minLen, size_t line = __LINE__)
+    void stripAndCheckLen(size_t start, size_t minLen, size_t line = __LINE__)
     {
-        value = _stripCFWS(valueBefore);
+        value = _stripCFWS(value[start .. value.length]);
         if (value.length < minLen)
             throw new DateTimeException("date-time value too short", __FILE__, line);
     }
-    stripAndCheckLen(value, "7Dec1200:00A".length);
+    stripAndCheckLen(0, "7Dec1200:00A".length);
 
     static if (isArray!R && (is(ElementEncodingType!R == char) || is(ElementEncodingType!R == ubyte)))
     {
@@ -10488,18 +10488,18 @@ if (isRandomAccessRange!R && hasSlicing!R && hasLength!R &&
             }
             default: throw new DateTimeException(format("Invalid day-of-week: %s", dowStr));
         }
-afterDoW: stripAndCheckLen(value[3 .. value.length], ",7Dec1200:00A".length);
+afterDoW: stripAndCheckLen(3, ",7Dec1200:00A".length);
         if (value[0] != ',')
             throw new DateTimeException("day-of-week missing comma");
-        stripAndCheckLen(value[1 .. value.length], "7Dec1200:00A".length);
+        stripAndCheckLen(1, "7Dec1200:00A".length);
     }
 
     // day
     immutable digits = isDigit(value[1]) ? 2 : 1;
     immutable day = _convDigits!short(value[0 .. digits]);
     if (day == -1)
         throw new DateTimeException("Invalid day");
-    stripAndCheckLen(value[digits .. value.length], "Dec1200:00A".length);
+    stripAndCheckLen(digits, "Dec1200:00A".length);
 
     // month
     Month month;
@@ -10518,7 +10518,7 @@ afterDoW: stripAndCheckLen(value[3 .. value.length], ",7Dec1200:00A".length);
             }
             default: throw new DateTimeException(format("Invalid month: %s", monStr));
         }
-afterMon: stripAndCheckLen(value[3 .. value.length], "1200:00A".length);
+afterMon: stripAndCheckLen(3, "1200:00A".length);
     }
 
     // year
@@ -10545,29 +10545,29 @@ afterMon: stripAndCheckLen(value[3 .. value.length], "1200:00A".length);
         else
             throw new DateTimeException("Invalid year. Cannot be earlier than 1900.");
     }
-    stripAndCheckLen(value[yearLen .. value.length], "00:00A".length);
+    stripAndCheckLen(yearLen, "00:00A".length);
 
     // hour
     immutable hour = _convDigits!short(value[0 .. 2]);
-    stripAndCheckLen(value[2 .. value.length], ":00A".length);
+    stripAndCheckLen(2, ":00A".length);
     if (value[0] != ':')
         throw new DateTimeException("Invalid hour");
-    stripAndCheckLen(value[1 .. value.length], "00A".length);
+    stripAndCheckLen(1, "00A".length);
 
     // minute
     immutable minute = _convDigits!short(value[0 .. 2]);
-    stripAndCheckLen(value[2 .. value.length], "A".length);
+    stripAndCheckLen(2, "A".length);
 
     // second
     short second;
     if (value[0] == ':')
     {
-        stripAndCheckLen(value[1 .. value.length], "00A".length);
+        stripAndCheckLen(1, "00A".length);
         second = _convDigits!short(value[0 .. 2]);
         // this is just if/until SysTime is sorted out to fully support leap seconds
         if (second == 60)
             second = 59;
-        stripAndCheckLen(value[2 .. value.length], "A".length);
+        stripAndCheckLen(2, "A".length);
     }
 
     immutable(TimeZone) parseTZ(int sign)

std/experimental/allocator/building_blocks/kernighan_ritchie.d

@@ -155,7 +155,7 @@ struct KRRegion(ParentAllocator = NullAllocator)
             if (leftover >= Node.sizeof)
             {
                 // There's room for another node
-                auto newNode = (() @trusted => cast(Node*) ((cast(ubyte*) &this) + bytes))();
+                auto newNode = (() @trusted => cast(Node*) (cast(size_t) &this + bytes))();
                 newNode.size = leftover;
                 newNode.next = next == &this ? newNode : next;
                 assert(next);

std/experimental/allocator/package.d

@@ -2108,10 +2108,10 @@ version (StdUnittest)
 
     void test(A)(auto ref A alloc)
     {
+        auto arr2 = arr;
         ForcedInputRange!int r;
         long[] a = alloc.makeArray!long(r);
         assert(a.length == 0 && a.ptr is null);
-        auto arr2 = arr;
         r.array = () @trusted { return &arr2; } ();
         a = alloc.makeArray!long(r);
         assert(a.length == 10);

std/internal/math/biguintcore.d

@@ -1514,7 +1514,7 @@ private int slowHighestPowerBelowUintMax(uint x) pure nothrow @safe
  * Returns:
  *    unique memory
  */
-BigDigit [] sub(const scope BigDigit [] x, const scope BigDigit [] y, bool *negative)
+BigDigit [] sub(const scope BigDigit [] x, const scope BigDigit [] y, scope bool *negative)
 pure nothrow @safe
 {
     if (x.length == y.length)
@@ -1606,7 +1606,7 @@ BigDigit [] add(const scope BigDigit [] a, const scope BigDigit [] b) pure nothr
 
 /**  return x + y
  */
-BigDigit [] addInt(const BigDigit[] x, ulong y) @safe pure nothrow
+BigDigit [] addInt(const scope BigDigit[] x, ulong y) @safe pure nothrow
 {
     uint hi = cast(uint)(y >>> 32);
     uint lo = cast(uint)(y& 0xFFFF_FFFF);
@@ -1633,7 +1633,7 @@ BigDigit [] addInt(const BigDigit[] x, ulong y) @safe pure nothrow
 /** Return x - y.
  *  x must be greater than y.
  */
-BigDigit [] subInt(const BigDigit[] x, ulong y) pure nothrow @safe
+BigDigit [] subInt(const scope BigDigit[] x, ulong y) pure nothrow @safe
 {
     uint hi = cast(uint)(y >>> 32);
     uint lo = cast(uint)(y & 0xFFFF_FFFF);

std/range/package.d

@@ -1037,7 +1037,7 @@ if (Ranges.length > 0 &&
                 frontIndex = source.length;
                 static if (bidirectional) backIndex = 0;
 
-                foreach (i, ref v; input) source[i] = v;
+                static foreach (i; 0 .. R.length) source[i] = input[i];
 
                 // We do this separately to avoid invoking `empty` needlessly.
                 // While not recommended, a range may depend on side effects of
@@ -1096,10 +1096,7 @@ if (Ranges.length > 0 &&
                     // TODO: this has the constructor needlessly refind
                     // frontIndex and backIndex. It'd be better to just copy
                     // those from `.this`.
-                    auto saveResult =
-                        Result(staticMap!(saveI, aliasSeqOf!(R.length.iota)));
-
-                    return saveResult;
+                    return Result(staticMap!(saveI, aliasSeqOf!(R.length.iota)));
                 }
             }