Repository navigation
Better error message when patch is the wrong type? #5113
Description
What happened?
If I attempt the supplied patch, kustomize errors.
What did you expect to happen?
The patch is applied, or, if not, a usable diagnostic as to what is wrong with the input given.
How can we reproduce it (as minimally and precisely as possible)?
# kustomization.yaml
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- argocd.yaml
patchesJson6902:
- target:
group: rbac.authorization.k8s.io
version: v1
kind: ClusterRole
name: argocd-server
patch:
- op: add
path: "/rules/3/verbs/2"
value: "update"apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
app.kubernetes.io/component: server
app.kubernetes.io/name: argocd-server
app.kubernetes.io/part-of: argocd
name: argocd-server
rules:
- apiGroups:
- '*'
resources:
- '*'
verbs:
- delete
- get
- patch
- apiGroups:
- ""
resources:
- events
verbs:
- list
- apiGroups:
- ""
resources:
- pods
- pods/log
verbs:
- get
- apiGroups:
- argoproj.io
resources:
- applications
verbs:
- get
- list
- watchExpected output
#[rest same as before]
- apiGroups:
- argoproj.io
resources:
- applications
verbs:
- get
- list
- update
- watchActual output
» kustomize build .
Error: invalid Kustomization: json: cannot unmarshal array into Go struct field Patch.patchesJson6902.patch of type string
Kustomize version
v5.0.1
Operating system
MacOS
Activity
roy-work commentedon Mar 29, 2023
Okay, this is partial user-error, but a.) this is really hard to see and b.) the error message could be loads more helpful in pointing me in the right direction here.
This:
patch:needs to be,
Kustomize requires the entire JSON patch to be double-encoded …
[-]Cannot add to array?[/-][+]Better error message when patch is the wrong type?[/+]koba1t commentedon Apr 5, 2023
I think
patchesJson6902.[].patchrequires the format of yaml string in multi-line literal is a reasonable reason.Because I think
patchesJson6902.[].patchis just converted for Yaml format of json6902.https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/patchesjson6902/
But I agree your opinion with be a better error message.
/triage accepted
k8s-triage-robot commentedon Apr 4, 2024
This issue has not been updated in over 1 year, and should be re-triaged.
You can:
/triage accepted(org members only)/closeFor more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
k8s-triage-robot commentedon Jul 3, 2024
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/staleis appliedlifecycle/stalewas applied,lifecycle/rottenis appliedlifecycle/rottenwas applied, the issue is closedYou can:
/remove-lifecycle stale/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
k8s-triage-robot commentedon Aug 2, 2024
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/staleis appliedlifecycle/stalewas applied,lifecycle/rottenis appliedlifecycle/rottenwas applied, the issue is closedYou can:
/remove-lifecycle rotten/closePlease send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
k8s-triage-robot commentedon Sep 1, 2024
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues according to the following rules:
lifecycle/staleis appliedlifecycle/stalewas applied,lifecycle/rottenis appliedlifecycle/rottenwas applied, the issue is closedYou can:
/reopen/remove-lifecycle rottenPlease send feedback to sig-contributor-experience at kubernetes/community.
/close not-planned
k8s-ci-robot commentedon Sep 1, 2024
@k8s-triage-robot: You can't close an active issue/PR unless you authored it or you are a collaborator.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
koba1t commentedon Sep 3, 2024
/lifecycle frozen