Skip to content
This repository was archived by the owner on Aug 8, 2023. It is now read-only.
This repository was archived by the owner on Aug 8, 2023. It is now read-only.

[core] Sync fill-extrusion-pattern sides rendering with GL-JS implementation  #15268

Open

Description

@astojilj

The issue behind failing fill-extrusion-pattern tests on GL native looks like having a different cause from mapbox/mapbox-gl-js#3327:
it is related to mapbox/geojson-vt-cpp#44 and usage of fixupPolygons / wagyu here:

// https://github.com/mapbox/geojson-vt-cpp/issues/44
.

As the order is different, edgedistance used for fill-extrusion-pattern side shader is different from gl-js. Tests now fail but are ignored.

Activity

  1. added
    GL JS parityFor feature parity with Mapbox GL JS
    CoreThe cross-platform C++ core, aka mbgl
    on Jul 31, 2019
  2. self-assigned this
    on Jul 31, 2019
  3. changed the title [-][core] Sync fill-extrusion-pattern sides rendering from GL-JS[/-] [+][core] Sync fill-extrusion-pattern sides rendering with GL-JS implementation [/+] on Jul 31, 2019
  4. removed their assignment
    on Jul 31, 2019
  5. astojilj commented on Jul 31, 2019

    @astojilj
    ContributorAuthor

    This is related to #8746 - while the issue #8746 is closed, ring order (input to classifyRings) in e.g. fill-extrussion-pattern/@2x render test between GL-JS and GL-native is different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CoreThe cross-platform C++ core, aka mbglGL JS parityFor feature parity with Mapbox GL JS

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions