[rush] rush alert should honor -q and --json and similar #5228

Activity

1. github-project-automation

   added this to Bug Triageon May 13, 2025
2. github-project-automation

   moved this to Needs triage in Bug Triageon May 13, 2025
3. iclanton commented on May 28, 2025

   

   Ian Clanton-Thuon (iclanton)

   on May 28, 2025

   Member

   More actions

   Looks like this was an oversight when that feature was implemented. Should be a fairly easy fix.
4. Ian Clanton-Thuon (iclanton)

   moved this from Needs triage to Low priority in Bug Triageon May 28, 2025
5. Ian Clanton-Thuon (iclanton)

   added

   help wantedIf you're looking to contribute, this issue is a good place to start!If you're looking to contribute, this issue is a good place to start!

   effort: easyProbably a quick fix. Want to contribute? :-)Probably a quick fix. Want to contribute? :-)

   on May 28, 2025
6. AryanBagade commented on Sep 3, 2025

   

   Aryan Bagade (AryanBagade)

   on Sep 3, 2025

   More actions

   Hi! Ian Clanton-Thuon (@iclanton) I’d like to take this issue, could you please assign it to me?

   Proposed approach:

   • Honor shouldRestrictConsoleOutput() for Rush alerts so -q / --quiet and --json suppress the alert banner.
   • Change site: libraries/rush-lib/src/cli/RushCommandLineParser.ts
     • Console restriction logic: https://github.com/microsoft/rushstack/blob/main/libraries/rush-lib/src/cli/RushCommandLineParser.ts#L205-L221
     • Alert invocation in onExecuteAsync(): https://github.com/microsoft/rushstack/blob/main/libraries/rush-lib/src/cli/RushCommandLineParser.ts#L255-L275
   • Minimal change (parser-level guard):
     if (!RushCommandLineParser.shouldRestrictConsoleOutput()) {
     await rushAlerts.printAlertsAsync();
     }

   Rationale:

   • Prevents alert output on stdout so commands like rush list --json | jq emit only JSON.
   • Keeps explicit rush alert behavior unchanged.

   Tests:

   • Add/extend a test to assert no alert output when --json or -q is present, and JSON remains valid.

   If this direction looks good, I’ll proceed from branch fix/5228-alert-honor-quiet-json. Thanks!