Skip to content

Commit a2d774a

Browse files
committed
add todo comments
1 parent 9f5c139 commit a2d774a

3 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎lib/prerequisites.js‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,15 @@ LOAD icu;
1212
-- identifiers with "_", not with "-", so we use pg_collation instead.
1313
-- see also https://duckdb.org/docs/sql/expressions/collations#icu-collations
1414
-- todo: Also, entries like "de_DE" are missing.
15+
-- todo: it *seems* that just \`no\` (as used by Entur) is valid:
16+
-- > langtag = language
17+
-- > ["-" script]
18+
-- > ["-" region]
19+
-- > *("-" variant)
20+
-- > *("-" extension)
21+
-- > ["-" privateuse]
22+
-- – https://www.rfc-editor.org/rfc/bcp/bcp47.txt
23+
-- see https://github.com/duckdb/duckdb/issues/20672
1524
CREATE TABLE valid_lang_codes (
1625
-- As of DuckDB v1.2.0, referring to this table via either a subquery or a plain foreign key doesn't work because
1726
-- - subqueries are prohibited in CHECK constraints, and

‎lib/stop_times.js‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,9 @@ WITH stop_times_based AS NOT MATERIALIZED (
206206
drop_off_type,
207207
shape_dist_traveled,
208208
timepoint,
209+
-- todo: simplify?
210+
-- see https://github.com/MobilityData/gtfs-validator/issues/130
211+
-- see https://github.com/MobilityData/gtfs-validator/blob/2919b7c76b299058f06a486feb987d9f3f6e23a2/main/src/main/java/org/mobilitydata/gtfsvalidator/validator/AgencyConsistencyValidator.java#L83-L92
209212
agency.agency_timezone as tz,
210213
arrival_time,
211214
(

‎lib/stops.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ const importData = async (db, pathToStops, opt, workingState) => {
3434
'platform_code',
3535
])
3636

37+
// todo: support new columns, e.g. tts_stop_name
38+
3739
await db[RUN](`\
3840
CREATE TYPE location_type_val AS ENUM (
3941
'stop' -- 0 (or blank): Stop (or Platform). A location where passengers board or disembark from a transit vehicle. Is called a platform when defined within a parent_station.

0 commit comments

Comments
 (0)