Include the platform in the downloads full name

downloads joined the gem name and version number by hand, so a Gems::Version for a non-ruby platform fetched the ruby build counts. full_name_of already builds the name the endpoint looks up.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Author: 2 people

lib/gems/api/download_endpoints.rb

@@ -31,8 +31,8 @@ def total_downloads
       # @example
       #   Gems.downloads("rails_admin", "0.0.1").version_downloads
       def downloads(gem_name, version = nil)
-        number = number_of(version) || latest_version(gem_name)
-        Downloads.new(JSON.parse(get("/api/v1/downloads/#{name_of(gem_name)}-#{number}.json")))
+        full_name = full_name_of(gem_name, version || latest_version(gem_name))
+        Downloads.new(JSON.parse(get("/api/v1/downloads/#{full_name}.json")))
       end
 
       # Returns the top 50 downloaded gem versions of all time

lib/gems/identifiers.rb

@@ -53,7 +53,7 @@ def platform_of(version)
     # @param version [String, Version] a version number or version
     # @param platform [String, nil] the platform; defaults to the platform of a version object
     # @return [String] the full name
-    def full_name_of(gem, version, platform)
+    def full_name_of(gem, version, platform = nil)
       ::Gem::NameTuple.new(name_of(gem), number_of(version), platform || platform_of(version)).full_name
     end
 

sig/gems.rbs

@@ -300,7 +300,7 @@ module Gems
     def name_of: (gem_identifier? gem) -> String?
     def number_of: (version_identifier? version) -> String?
     def platform_of: (version_identifier? version) -> String?
-    def full_name_of: (gem_identifier gem, version_identifier version, String? platform) -> String
+    def full_name_of: (gem_identifier gem, version_identifier version, ?String? platform) -> String
     def handle_of: (user_identifier owner) -> (String | Integer)?
     def url_of: (web_hook_identifier web_hook) -> String?
     def key_of: (api_key_identifier? api_key) -> String?

spec/gems/api/download_endpoints_spec.rb

@@ -37,6 +37,13 @@
       expect([downloads.class, downloads.total, downloads.version_downloads]).to eq([Gems::Downloads, 3142, 3142])
     end
 
+    it "includes the platform of a version in the full name" do
+      stub_get("/api/v1/downloads/nokogiri-1.15.0-java.json").to_return(body: fixture("rails_admin-0.0.0.json"))
+      client.downloads("nokogiri", Gems::Version.new("number" => "1.15.0", "platform" => "java"))
+
+      expect(a_get("/api/v1/downloads/nokogiri-1.15.0-java.json")).to have_been_made
+    end
+
     it "defaults to the latest version" do
       stub_get("/api/v1/versions/rails_admin/latest.json").to_return(body: '{"version":"3.0.9"}')
       stub_get("/api/v1/downloads/rails_admin-3.0.9.json").to_return(body: fixture("rails_admin-0.0.0.json"))

spec/gems/identifiers_spec.rb

@@ -45,7 +45,7 @@
 
   describe "#full_name_of" do
     it "joins the name and number" do
-      expect(client.send(:full_name_of, "rails", "7.0.6", nil)).to eq("rails-7.0.6")
+      expect(client.send(:full_name_of, "rails", "7.0.6")).to eq("rails-7.0.6")
     end
 
     it "appends the platform" do
@@ -59,7 +59,7 @@
     it "defaults to the platform of a version" do
       version = Gems::Version.new("name" => "nokogiri", "number" => "1.15.0", "platform" => "java")
 
-      expect(client.send(:full_name_of, version, version, nil)).to eq("nokogiri-1.15.0-java")
+      expect(client.send(:full_name_of, version, version)).to eq("nokogiri-1.15.0-java")
     end
 
     it "prefers an explicit platform" do