Skip to content

Commit 57a4adc

Browse files
committed
Fix infinite render loop on submissions table checkboxes
onChange={row.toggleSelected()} invoked the state setter during render, causing React error #185 (maximum update depth exceeded) whenever the submissions table rendered. Wrap in an arrow function so selection only changes on the change event.
1 parent ea2e66a commit 57a4adc

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/components/forms/applications/data-table.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ export function DataTable<TData, TValue>({
9797
<input
9898
type="checkbox"
9999
checked={table.getIsAllPageRowsSelected()}
100-
onChange={table.toggleAllPageRowsSelected}
100+
onChange={() => table.toggleAllPageRowsSelected()}
101101
onClick={(e) => e.stopPropagation()}
102102
className="accent-lp-500 w-3.5 h-3.5 cursor-pointer"
103103
title="Select page"
@@ -107,7 +107,7 @@ export function DataTable<TData, TValue>({
107107
<input
108108
type="checkbox"
109109
checked={row.getIsSelected()}
110-
onChange={row.toggleSelected()}
110+
onChange={() => row.toggleSelected()}
111111
onClick={(e) => e.stopPropagation()}
112112
className="accent-lp-500 w-3.5 h-3.5 cursor-pointer"
113113
/>

0 commit comments

Comments
 (0)