Repository navigation
Accept normalized CLA signature comments - #28
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the sole change in .github/workflows/cla.yml. The broader signature gate correctly allows comments with surrounding whitespace or Markdown to reach the CLA action while leaving recheck exact as intended; no concrete correctness, security, compatibility, or performance issue found. LGTM.
|
🎉 This PR has been merged—thank you, @glenn-jocher!
Your update to |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow gate to detect signature comments containing the required CLA text, allowing normalized signatures with surrounding whitespace or Markdown to reach the action matcher.
📊 Key Changes
contains()check in.github/workflows/cla.yml.recheckcommand comparison exact.🎯 Purpose & Impact