Repository navigation
notebook static checks hard gate is failing on main: AMD-Qwen3_(4B)-GRPO-Tool_Use lost its unsloth-zoo git install #403
Description
notebook static checks (HARD GATE) is failing on main, which blocks every PR in this repo.
FAILED tests/test_amd_git_main_unsloth_install.py::test_generated_amd_notebooks_match_their_source[AMD-Qwen3_(4B)-GRPO-Tool_Use.ipynb-Qwen3_(4B)-GRPO-Tool_Use.ipynb]
E AssertionError: AMD-Qwen3_(4B)-GRPO-Tool_Use.ipynb lost git+https://github.com/unslothai/unsloth-zoo
Reproduced on a clean git worktree of origin/main at 31a8d59: 1 failed, 35 passed, 125 skipped. The whole suite shows 18 failures there, all on the two notebooks added in #395 (Qwen3_(4B)-GRPO-Tool_Use and Qwen3_(4B)-Tool_Calling) across their AMD, Kaggle and HuggingFace Course variants, split between this test and test_python_scripts_regen_parity.py.
The AMD generation step is expected to carry the git+https://github.com/unslothai/unsloth-zoo install through to the AMD variant, and for this notebook it does not. The AMD install cell is the ROCm %%bash block, so whatever rewrites it for the Qwen3 (4B) tool-use source is dropping that line.
Noting it rather than fixing it, since it belongs to #395 and I do not want to guess at the intended ROCm install for those notebooks. I hit it while landing #402, which is unrelated to the AMD variants and merged with this failure recorded as pre-existing.
Activity
NoahSabb commentedon Oct 17, 2026
I'm working on this. Question: should the AMD variants of the two #395 notebooks keep the git-main unsloth / unsloth-zoo install (re-emitted after the ROCm block with
--no-deps)? And should the PR also fix thepython_scriptsregen parity failures, or just the AMD one?danielhanchen commentedon Oct 22, 2026
Fixed! The generator was building the AMD Qwen3 (4B) GRPO tool-use notebook from the plain GRPO install extras, so the git main unsloth / unsloth-zoo line its CUDA and Kaggle versions carry never reached the AMD variant. That is fixed in #407, which also regenerates the tool-use and tool-calling python_scripts mirrors and stops the vLLM pin test from treating
find_spec("vllm")as an unpinned install. The static gate is green on main again.To update: re-open
AMD-Qwen3_(4B)-GRPO-Tool_Use.ipynbfrom the repo to get the new install cell. Reopen if it still happens.