refactor: give each kind of setting field its own type

SettingField held the options for every kind of field and a FieldKind
saying which applied, so nothing stopped a spin option on a checkbox or
a combo without choices, and the form branched on the kind in four
places. Each kind is now its own class taking only its own options,
with the required ones required, and the form builds, fills and reads
each through a matching editor.

The crop field's spin_max went with it: the crop picker has no maximum,
so it was never read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MTS355x5fJ6RENK1HLYqmX

Author: claude

gridplayer/params/defaults_fields.py

@@ -9,7 +9,7 @@
 )
 from gridplayer.models.playlist import Playlist
 from gridplayer.models.video import Video
-from gridplayer.params.defaults_fields import VIDEO_FIELDS, FieldKind
+from gridplayer.params.defaults_fields import VIDEO_FIELDS, ComboField, TextField
 from gridplayer.params.static import AudioTrackMode
 from gridplayer.playlist_settings import (
     PlaylistSettings,
@@ -66,8 +66,8 @@ def test_languages_field_follows_the_mode_field():
 def test_languages_field_is_a_text_box_with_an_example_in_it():
     spec = _spec(LANGUAGES_KEY)
 
-    assert spec.kind is FieldKind.TEXT
-    assert spec.text_placeholder
+    assert isinstance(spec, TextField)
+    assert spec.placeholder
 
 
 def test_text_field_renders_a_line_edit():
@@ -77,7 +77,7 @@ def test_text_field_renders_a_line_edit():
     widget = form._widgets[LANGUAGES_KEY]
 
     assert isinstance(widget, QLineEdit)
-    assert widget.placeholderText() == _spec(LANGUAGES_KEY).text_placeholder
+    assert widget.placeholderText() == _spec(LANGUAGES_KEY).placeholder
 
 
 def test_text_field_round_trips_its_value():
@@ -190,9 +190,9 @@ class TestTheAudioTrackDefaultIsAChoiceOfThree:
     def test_the_field_offers_them_by_name(self):
         spec = _spec(MODE_KEY)
 
-        assert spec.kind is FieldKind.COMBO
+        assert isinstance(spec, ComboField)
         assert spec.label == "Audio track"
-        assert list(spec.combo_values()) == [
+        assert list(spec.choices()) == [
             AudioTrackMode.DEFAULT,
             AudioTrackMode.PREFERRED,
             AudioTrackMode.DISABLED,

gridplayer/widgets/defaults_form.py

@@ -1682,7 +1682,7 @@ def test_in_the_lists_section_of_the_playlist_s(self):
 
         assert field.playlist_attr == "list_update"
         assert field.label == "Update linked lists"
-        assert list(field.combo_values().values()) == [
+        assert list(field.choices().values()) == [
             "On playlist load",
             "Every 5 minutes",
             "Every 15 minutes",

tests/test_audio_track_defaults.py

@@ -14,7 +14,11 @@
 
 from gridplayer.models.playlist import Playlist
 from gridplayer.params.actions import ACTIONS
-from gridplayer.params.defaults_fields import PLAYLIST_FIELDS, FieldKind
+from gridplayer.params.defaults_fields import (
+    PLAYLIST_FIELDS,
+    CheckboxField,
+    FloatSpinField,
+)
 from gridplayer.params.static import MAX_SCALE, MIN_SCALE
 from gridplayer.player.managers.video_blocks import VideoBlocksManager
 from gridplayer.playlist_settings import PlaylistSettings, overrides_from_playlist
@@ -102,14 +106,14 @@ def test_seek_steps_are_set_to_the_millisecond(self):
         fields = {spec.settings_key: spec for spec in PLAYLIST_FIELDS}
 
         for key in STEP_KEYS[:3]:
-            assert fields[key].kind is FieldKind.FLOAT_SPIN
-            assert fields[key].spin_decimals == 3
-            assert fields[key].spin_min == 0.001
+            assert isinstance(fields[key], FloatSpinField)
+            assert fields[key].decimals == 3
+            assert fields[key].minimum == 0.001
 
     def test_proportional_zoom_is_a_checkbox(self):
         fields = {spec.settings_key: spec for spec in PLAYLIST_FIELDS}
 
-        assert fields["playlist/zoom_proportional"].kind is FieldKind.CHECKBOX
+        assert isinstance(fields["playlist/zoom_proportional"], CheckboxField)
 
 
 class TestTheForm:

tests/test_linked_lists.py

@@ -212,7 +212,7 @@ def test_it_sits_with_the_rest_of_the_subtitle_defaults(self):
         spec = next(f for f in VIDEO_FIELDS if f.settings_key == SETTING)
 
         assert spec.video_attr == "subtitle_encoding"
-        assert spec.combo_values is _subtitle_encodings
+        assert spec.choices is _subtitle_encodings
         # it has to apply to a track picked from the menu too, not only to
         # one a video opens with, so nothing gates it
         assert spec.enabled_by is None

tests/test_step_sizes.py

@@ -15,7 +15,7 @@
 from gridplayer.models.grid_state import GridState
 from gridplayer.models.video import Video
 from gridplayer.params.actions import ACTIONS
-from gridplayer.params.defaults_fields import PLAYLIST_FIELDS, FieldKind
+from gridplayer.params.defaults_fields import PLAYLIST_FIELDS, CheckboxField
 from gridplayer.params.menu import SECTIONS, SUBMENUS
 from gridplayer.params.static import (
     SeekSyncMode,
@@ -181,7 +181,7 @@ def test_they_are_together_with_seek_sync_in_a_section_of_their_own(self):
             "pause_sync",
             "rate_sync",
         ]
-        assert all(field.kind == FieldKind.CHECKBOX for field in fields[1:])
+        assert all(isinstance(field, CheckboxField) for field in fields[1:])
 
 
 def _block(is_initialized=True, has_picture=True, is_live=False):

tests/test_subtitle_encoding.py

@@ -20,7 +20,7 @@
 from gridplayer.models.playlist import Playlist, PlaylistVideoDefaults
 from gridplayer.models.video import Video
 from gridplayer.params.actions import ACTIONS
-from gridplayer.params.defaults_fields import VIDEO_FIELDS, FieldKind
+from gridplayer.params.defaults_fields import VIDEO_FIELDS, CheckboxField
 from gridplayer.params.menu import SECTIONS, SUBMENUS
 from gridplayer.params.static import (
     MAX_SCALE,
@@ -176,7 +176,7 @@ def test_the_alignment_sits_under_crop_in_the_video_section(self):
         spec = VIDEO_FIELDS[at + 1]
         assert spec.section == "Video"
         assert spec.video_attr == "anchor"
-        assert list(spec.combo_values()) == list(VideoAnchor)
+        assert list(spec.choices()) == list(VideoAnchor)
 
     def test_letting_it_past_the_edges_sits_under_the_alignment(self):
         keys = [f.settings_key for f in VIDEO_FIELDS]
@@ -186,7 +186,7 @@ def test_letting_it_past_the_edges_sits_under_the_alignment(self):
 
         spec = VIDEO_FIELDS[at + 1]
         assert spec.section == "Video"
-        assert spec.kind == FieldKind.CHECKBOX
+        assert isinstance(spec, CheckboxField)
         assert spec.video_attr == "shift_past_edges"
 
     def test_zooming_to_the_cursor_sits_under_the_zoom(self):
@@ -197,7 +197,7 @@ def test_zooming_to_the_cursor_sits_under_the_zoom(self):
 
         spec = VIDEO_FIELDS[at + 1]
         assert spec.section == "Video"
-        assert spec.kind == FieldKind.CHECKBOX
+        assert isinstance(spec, CheckboxField)
         assert spec.video_attr == "zoom_to_cursor"
 
     def test_there_is_no_default_for_the_position(self):

tests/test_sync.py

@@ -6,7 +6,11 @@
 
 from gridplayer.models.playlist import Playlist
 from gridplayer.models.video import Video
-from gridplayer.params.defaults_fields import VIDEO_FIELDS
+from gridplayer.params.defaults_fields import (
+    PLAYLIST_FIELDS,
+    SUBTITLE_STYLE_FIELDS,
+    VIDEO_FIELDS,
+)
 from gridplayer.params.static import VideoCrop, VideoEndAction, VideoInitialState
 from gridplayer.playlist_settings import (
     PlaylistSettings,
@@ -252,3 +256,19 @@ def test_settings_get_all_includes_new_defaults():
     assert values["video_defaults/rate"] == _default_settings["video_defaults/rate"]
     assert values["video_defaults/crop"] == VideoCrop(0, 0, 0, 0)
     assert values["video_defaults/color"] == "#ffffff"
+
+
+@pytest.mark.parametrize(
+    "fields",
+    [PLAYLIST_FIELDS, VIDEO_FIELDS, SUBTITLE_STYLE_FIELDS],
+    ids=["playlist", "video", "subtitle_style"],
+)
+def test_defaults_form_gives_back_every_default_it_is_given(fields):
+    defaults = {
+        spec.settings_key: _default_settings[spec.settings_key] for spec in fields
+    }
+    form = DefaultsForm(fields, show_reset=True)
+
+    form.set_values(defaults)
+
+    assert form.values() == defaults