Building from main doesn't react on Esc

[y9san9]

I might've missed some breaking changes, here's my config:

[general]
# hide_overlay_in_screen_share = true
passthrough_unbounded_keys = true

[hotkeys]
"Option+Escape" = "recursive_grid"
"Option+Tab" = "scroll"
"Option+Space" = "action left_click"

[mode_indicator.ui]
font_size = 4
border_radius = 50
border_color_light = "#00000000"
border_color_dark = "#00000000"
border_width = 0
padding_x = -1
padding_y = -1
indicator_x_offset = 10
indicator_y_offset = -20

[mode_indicator.scroll]
enabled = true
text = " "
background_color_light = "#FF00CF55"
background_color_dark = "#FF00CF55"

[mode_indicator.recursive_grid]
enabled = true
text = " "
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[sticky_modifiers.ui]
indicator_y_offset = 20
indicator_x_offset = 0
border_width = 0
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[action.key_bindings]
middle_click = "Shift+M"
mouse_down = "Shift+D"
mouse_up = "Shift+U"
move_mouse_up = "Up"
move_mouse_down = "Down"
move_mouse_left = "Left"
move_mouse_right = "Right"

[scroll.key_bindings]
scroll_up = ["Ctrl+K"]
scroll_down = ["Ctrl+J"]
scroll_left = ["Ctrl+H"]
scroll_right = ["Ctrl+L"]
page_up = ["Ctrl+U"]
page_down = ["Ctrl+D"]
go_top = ["Ctrl+T"]
go_bottom = ["Ctrl+B"]

[scroll.custom_hotkeys]
"," = "recursive_grid"
"Space" = ["action left_click", "idle"]
"Shift+Space" = "action left_click"
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = "action right_click"

[recursive_grid]
reset_key = ","

# grid_cols = 3
# grid_rows = 3
# keys = "aksh ldjf"

grid_cols = 5
grid_rows = 5
keys = "qwertasdfgcvbnmyuiophjkl;"

min_size = 10
max_depth = 10

[recursive_grid.ui]
label_font_size = 8

# For colored grid

line_color_light = "#33FF0000"
text_color_light = "#00000000"
highlight_color_light = "#00FFFFFF"

line_color_dark = "#33FF0000"
text_color_dark = "#00000000"
highlight_color_dark = "#00FFFFFF"

sub_key_preview = true
sub_key_preview_font_size = 6
sub_key_preview_text_color_light = "#55FF0000"
sub_key_preview_text_color_dark = "#55FF0000"

# For transparent grid

# line_color_light = "#00000000"
# text_color_light = "#00000000"
# highlight_color_light = "#00000000"
#
# line_color_dark = "#00000000"
# text_color_dark = "#00000000"
# highlight_color_dark = "#00000000"

[recursive_grid.custom_hotkeys]
"Space" = ["action left_click", "idle"]
"Shift+Space" = ["action left_click", "exec sleep 0.05", "recursive_grid"]
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = ["action right_click", "exec sleep 0.05", "recursive_grid"]

"Ctrl+J" = "action scroll_down"
"Ctrl+K" = "action scroll_up"
"Ctrl+H" = "action scroll_left"
"Ctrl+L" = "action scroll_right"
"Ctrl+U" = "action page_up"
"Ctrl+D" = "action page_down"
"Ctrl+T" = "action go_top"
"Ctrl+B" = "action go_bottom"

[smooth_cursor]
move_mouse_enabled = true
steps = 50
max_duration = 200
duration_per_pixel = 0.1

[systray]
enabled = false

Is it expected to not react on backspace and Escape?

[y9san9]

@y3owk1n I think there should be some defaults for hotkeys like esc and backspace, otherwise you need to configure soo much things.

But overall I think you did great with migrating things. The only thing to mention is that custom_hotkeys can probably be just hotkeys and it will be much more user-friendly in my opinion for newcoming users

[y9san9]

Yeah, after a little more thinking I think it makes sense to rename it to hotkeys because we already have global [hotkeys] section that works basically just like that

[y3owk1n]

I've thought about it, and normally new users should already copy the default config, which is included by default. I havent yet write a good enough migration guide yet, so it will be a bit confusing for existing main build user.

There's no simple way to maintain a default in string[] toml configuration, as far as for now, it will be either if you fully omit it, it will populate all the default, and if you put one key in the array, it will just use the one key and disregard all the defaults set.

Also I do not want to have any action that is hardcoded in the codebase anymore. Whenever there are changes (be it addition or new feature), there's too many places that needs to be updated. With this change, new features can be introduce in a cli action format, and user just bind it whenever they want to.

Here's a version for your config:

[general]
# hide_overlay_in_screen_share = true
passthrough_unbounded_keys = true

[hotkeys]
"Option+Escape" = "recursive_grid"
"Option+Tab" = "scroll"
"Option+Space" = "action left_click"

[mode_indicator.ui]
font_size = 4
border_radius = 50
border_color_light = "#00000000"
border_color_dark = "#00000000"
border_width = 0
padding_x = -1
padding_y = -1
indicator_x_offset = 10
indicator_y_offset = -20

[mode_indicator.scroll]
enabled = true
text = " "
background_color_light = "#FF00CF55"
background_color_dark = "#FF00CF55"

[mode_indicator.recursive_grid]
enabled = true
text = " "
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[sticky_modifiers.ui]
indicator_y_offset = 20
indicator_x_offset = 0
border_width = 0
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[scroll.custom_hotkeys]
# escape
"Escape" = "idle"
# reset
"," = "recursive_grid"
# scroll navigation
"Ctrl+K" = "action scroll_up"
"Ctrl+J" = "action scroll_down"
"Ctrl+H" = "action scroll_left"
"Ctrl+L" = "action scroll_right"
"Ctrl+T" = "action go_top"
"Ctrl+B" = "action go_bottom"
"Ctrl+U" = "action page_up"
"Ctrl+D" = "action page_down"
# actions
"Shift+M" = "action middle_click"
"Shift+D" = "action mouse_down"
"Shift+U" = "action mouse_up"
"Up" = "action move_mouse_relative --dx=0 --dy=-10"
"Down" = "action move_mouse_relative --dx=0 --dy=10"
"Left" = "action move_mouse_relative --dx=-10 --dy=0"
"Right" = "action move_mouse_relative --dx=10 --dy=0"
# others
"Space" = ["action left_click", "idle"]
"Shift+Space" = "action left_click"
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = "action right_click"

[recursive_grid]
# grid_cols = 3
# grid_rows = 3
# keys = "aksh ldjf"

grid_cols = 5
grid_rows = 5
keys = "qwertasdfgcvbnmyuiophjkl;"

min_size = 10
max_depth = 10

[recursive_grid.ui]
label_font_size = 8

# For colored grid

line_color_light = "#33FF0000"
text_color_light = "#00000000"
highlight_color_light = "#00FFFFFF"

line_color_dark = "#33FF0000"
text_color_dark = "#00000000"
highlight_color_dark = "#00FFFFFF"

sub_key_preview = true
sub_key_preview_font_size = 6
sub_key_preview_text_color_light = "#55FF0000"
sub_key_preview_text_color_dark = "#55FF0000"

# For transparent grid

# line_color_light = "#00000000"
# text_color_light = "#00000000"
# highlight_color_light = "#00000000"
#
# line_color_dark = "#00000000"
# text_color_dark = "#00000000"
# highlight_color_dark = "#00000000"

[recursive_grid.custom_hotkeys]
# escape
"Escape" = "idle"
# reset
"," = "action reset"
# scroll navigation
"Ctrl+J" = "action scroll_down"
"Ctrl+K" = "action scroll_up"
"Ctrl+H" = "action scroll_left"
"Ctrl+L" = "action scroll_right"
"Ctrl+U" = "action page_up"
"Ctrl+D" = "action page_down"
"Ctrl+T" = "action go_top"
"Ctrl+B" = "action go_bottom"
# actions
"Shift+M" = "action middle_click"
"Shift+D" = "action mouse_down"
"Shift+U" = "action mouse_up"
"Up" = "action move_mouse_relative --dx=0 --dy=-10"
"Down" = "action move_mouse_relative --dx=0 --dy=10"
"Left" = "action move_mouse_relative --dx=-10 --dy=0"
"Right" = "action move_mouse_relative --dx=10 --dy=0"
# others
"Space" = ["action left_click", "idle"]
"Shift+Space" = ["action left_click", "exec sleep 0.05", "recursive_grid"]
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = ["action right_click", "exec sleep 0.05", "recursive_grid"]


[smooth_cursor]
move_mouse_enabled = true
steps = 50
max_duration = 200
duration_per_pixel = 0.1

[systray]
enabled = false

[y9san9]

Yeah thanks I migrated already

[y9san9]

Kind of cursed that that is basically a minimal thing you have to have to use neru now. I think overall refactoring was very much needed but now we need to think about sensible defaults

[y3owk1n]

Projects like https://glidewm.org/reference/config/ fix this with a toggle for whether you want to use the default keys and whatever you add will addition to the defaults.

[y3owk1n]

This is the next thing where I want to make our toml parser more intelligent in this sense before the next release. You might need to update your config again later... hahaha

[y3owk1n]

See #646

[y3owk1n]

@y9san9 I have done some changes at #647, feel free to check it out. It's definitely an improvement in my opinion. The idea is that,

we try to merge the defaults in whenever we able to, and user have to explicitly disable the defaults if they dont want it at all.

Which means that your config can be now:

[general]
# hide_overlay_in_screen_share = true
passthrough_unbounded_keys = true

[hotkeys]
# disable defaults
"Cmd+Shift+Space" = "__disabled__"
"Cmd+Shift+G" = "__disabled__"
"Cmd+Shift+C" = "__disabled__"
"Cmd+Shift+S" = "__disabled__"

"Option+Escape" = "recursive_grid"
"Option+Tab" = "scroll"
"Option+Space" = "action left_click"

[mode_indicator.ui]
font_size = 4
border_radius = 50
border_color_light = "#00000000"
border_color_dark = "#00000000"
border_width = 0
padding_x = -1
padding_y = -1
indicator_x_offset = 10
indicator_y_offset = -20

[mode_indicator.scroll]
enabled = true
text = " "
background_color_light = "#FF00CF55"
background_color_dark = "#FF00CF55"

[mode_indicator.recursive_grid]
enabled = true
text = " "
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[sticky_modifiers.ui]
indicator_y_offset = 20
indicator_x_offset = 0
border_width = 0
background_color_light = "#FFFFAA22"
background_color_dark = "#FFFFAA22"

[scroll.custom_hotkeys]
# disable defaults
"Shift+L" = "__disabled__"
"Shift+R" = "__disabled__"
"Shift+I" = "__disabled__"

# reset
"," = "recursive_grid"
# scroll navigation
"Ctrl+K" = "action scroll_up"
"Ctrl+J" = "action scroll_down"
"Ctrl+H" = "action scroll_left"
"Ctrl+L" = "action scroll_right"
"Ctrl+T" = "action go_top"
"Ctrl+B" = "action go_bottom"
"Ctrl+U" = "action page_up"
"Ctrl+D" = "action page_down"
# actions
"Shift+M" = "action middle_click"
"Shift+D" = "action mouse_down"
"Shift+U" = "action mouse_up"
# others
"Space" = ["action left_click", "idle"]
"Shift+Space" = "action left_click"
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = "action right_click"

[recursive_grid]
# grid_cols = 3
# grid_rows = 3
# keys = "aksh ldjf"

grid_cols = 5
grid_rows = 5
keys = "qwertasdfgcvbnmyuiophjkl;"

min_size = 10
max_depth = 10

[recursive_grid.ui]
label_font_size = 8

# For colored grid

line_color_light = "#33FF0000"
text_color_light = "#00000000"
highlight_color_light = "#00FFFFFF"

line_color_dark = "#33FF0000"
text_color_dark = "#00000000"
highlight_color_dark = "#00FFFFFF"

sub_key_preview = true
sub_key_preview_font_size = 6
sub_key_preview_text_color_light = "#55FF0000"
sub_key_preview_text_color_dark = "#55FF0000"

# For transparent grid

# line_color_light = "#00000000"
# text_color_light = "#00000000"
# highlight_color_light = "#00000000"
#
# line_color_dark = "#00000000"
# text_color_dark = "#00000000"
# highlight_color_dark = "#00000000"

[recursive_grid.custom_hotkeys]
# disable defaults
"Shift+L" = "__disabled__"
"Shift+R" = "__disabled__"
"Shift+I" = "__disabled__"
"k" = "__disabled__"
"j" = "__disabled__"
"h" = "__disabled__"
"l" = "__disabled__"
"gg" = "__disabled__"
"Shift+G" = "__disabled__"
"u" = "__disabled__"
"d" = "__disabled__"

# reset
"," = "action reset"
# scroll navigation
"Ctrl+J" = "action scroll_down"
"Ctrl+K" = "action scroll_up"
"Ctrl+H" = "action scroll_left"
"Ctrl+L" = "action scroll_right"
"Ctrl+U" = "action page_up"
"Ctrl+D" = "action page_down"
"Ctrl+T" = "action go_top"
"Ctrl+B" = "action go_bottom"
# actions
"Shift+M" = "action middle_click"
"Shift+D" = "action mouse_down"
"Shift+U" = "action mouse_up"
# others
"Space" = ["action left_click", "idle"]
"Shift+Space" = ["action left_click", "exec sleep 0.05", "recursive_grid"]
"Cmd+Space" = ["action right_click", "idle"]
"Cmd+Shift+Space" = ["action right_click", "exec sleep 0.05", "recursive_grid"]


[smooth_cursor]
move_mouse_enabled = true
steps = 50
max_duration = 200
duration_per_pixel = 0.1

[systray]
enabled = false

is it any better or worst? I am not so sure, as you have tons of custom bindings, that's why needs more __disable__. But for new users, maybe its easier?

[y9san9]

I think this is better. Even if I have to disable this defaults it doesn't matter much since I already have strong preferences, but newcomers will have less problems

[y9san9]

Finally I did what I wanted from the start! cc @y3owk1n

[y3owk1n]

very nice ~ i hope someday, everyone have different config that suits them, just like our neovim config.

[y9san9]

I already like it so much. For the last week it started to feel more native. That includes me being more trained now and some of the latter updates

[y3owk1n]

by the way, i think i will change the custom_hotkeys to just hotkeys as per your suggestion, so when it landed, you'll need to update your config again.. sorry about that ~

[y9san9]

Nah, don't worry, it's all good on my side. I am all for such changes, it's better to break it now for brighter future. I am following all the news and change my config accordingly