You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have a basic DND feature in the left sidebar which activates the DND mode and to deactivate user need to update it manually. It would be great to have something like -
Enable DND mode for X minutes/hrs/day
and then automatically handles the notification setting after the DND time gets over.
Two things we need to do here - a) UI/UX - I think we can show the time within the tooltip itself b) How to calculate the DND time since there could be multiple cases like the laptop is switched off/sleep etc.
To implement this I have/had a rough plan in mind:
First we should create the UX/UI in a new branch or that only shows up in development mode.
Then, once we have the UI, we can set up the turn on/off thing per input provided by the user.
Lastly, we should save in JsonDB the end-time of DND time, so it just a one if statement on the start of the app to turn it off or schedule a timer if it not done yet.
For step two, we can use something like node-schedule to do turn off the DND button after the specified time, in which case if the app is closed or device shut-down it will not work. Which we will need to cover in step three.
I know this is the repository for the electron app, but can you clarify why you see DND as an app setting rather than a profile-setting?
Imho it leads to confusion and unwanted behaviour if there is a DND layer above a profile setting.
If I don't want to be disturbed, then I do so in my online status which should then reflect across all apps.
similarly if i want to receive notifications again, I should be able to do so on mobile and the changes should reflect on desktop.
that's why I think this should be followed further (only) as a profile setting and not as an app setting.
Thanks for the link. As it seems the main reasonis this statement by @timabbott
I think it's actually probably useful to have a desktop app feature for this, because if you're in multiple organizations, you kida want to be able to turn it off for all of them at once.
I agree that this is a very good point, which i didn't consider before.
I would still prefer if this kind of status-change would reflect consistently over web, desktop and mobile.
How to communicate over multiple organizations a common state - I have no idea.
An approach to change an additonal notification-status in each logged in organization would be an option, maybe.
Welcome to Zulip, @manavmehta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Welcome to Zulip, @lolostheman! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
Join me on the Zulip developers' server, to get help, chat about this issue, and meet the other developers.
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
@lolostheman You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!
Activity
priyank-p commentedon Sep 15, 2018
To implement this I have/had a rough plan in mind:
First we should create the UX/UI in a new branch or that only shows up in development mode.
Then, once we have the UI, we can set up the turn on/off thing per input provided by the user.
Lastly, we should save in
JsonDBthe end-time of DND time, so it just a one if statement on the start of the app to turn it off or schedule a timer if it not done yet.For step two, we can use something like
node-scheduleto do turn off the DND button after the specified time, in which case if the app is closed or device shut-down it will not work. Which we will need to cover in step three.lukasIO commentedon Sep 15, 2018
I know this is the repository for the electron app, but can you clarify why you see DND as an app setting rather than a profile-setting?
Imho it leads to confusion and unwanted behaviour if there is a DND layer above a profile setting.
If I don't want to be disturbed, then I do so in my online status which should then reflect across all apps.
similarly if i want to receive notifications again, I should be able to do so on mobile and the changes should reflect on desktop.
that's why I think this should be followed further (only) as a profile setting and not as an app setting.
akashnimare commentedon Sep 17, 2018
@lukasIO please see the relevant conversations here - https://chat.zulip.org/#narrow/stream/16-desktop/topic/DND.20button
lukasIO commentedon Sep 17, 2018
Thanks for the link. As it seems the main reasonis this statement by @timabbott
I agree that this is a very good point, which i didn't consider before.
I would still prefer if this kind of status-change would reflect consistently over web, desktop and mobile.
How to communicate over multiple organizations a common state - I have no idea.
An approach to change an additonal notification-status in each logged in organization would be an option, maybe.
akashnimare commentedon Sep 17, 2018
For the webapp - zulip/zulip#295
akashnimare commentedon Sep 18, 2018
For the UI thing, we could show something like this in the tooltip -
manavmehta commentedon Mar 3, 2020
@zulipbot claim
zulipbot commentedon Mar 3, 2020
Welcome to Zulip, @manavmehta! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
Add feature to enable time based DND Mode
21 remaining items
lolostheman commentedon May 1, 2025
@zulipbot claim
zulipbot commentedon May 1, 2025
Welcome to Zulip, @lolostheman! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip-desktop/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!
Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.
See you on the other side (that is, the pull request side)!
dnd: Restore tooltip visibility after duration selection and improve …
main: Handle toggle-dnd-request and auto-revert DND in ipcMain.
main: Handle toggle-dnd-request and auto-revert DND in ipcMain.
main: Handle toggle-dnd-request and auto-revert DND in ipcMain.
zulipbot commentedon Dec 31, 2025
@lolostheman You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!
Added time durations for DND tooltip. Fixes zulip#561
Fixed spacing errors for tests. FIxes zulip#561
Paperyduke6 commentedon Mar 16, 2026
Hi, I have submitted a PR #1502, I have read and followed the approach of #1419 with the required improvements.
Added time durations for DND tooltip. Fixes zulip#561