Repository navigation
[pull] master from curl:master - #1661
Merged
Merged
Conversation
These methods generally access class variables so this is better than @staticmethod. Closes #23148
BoringSSL builds static libs by default. Switch to this default and adjust curl build options to link with it correctly, with default GCC. Slight downside is that libcurl must be built statically also, to avoid: ``` /usr/bin/ld: /home/runner/boringssl/lib/libssl.a(extensions.cc.o): warning: relocation against `_ZTVSt18bad_variant_access' in read-only section `.text._ZNSt18bad_variant_accessD2Ev[_ZNSt18bad_variant_accessD5Ev]' /usr/bin/ld: /home/runner/boringssl/lib/libssl.a(extensions.cc.o): relocation R_X86_64_PC32 against symbol `_ZTVSt9exception@@GLIBCXX_3.4' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value ``` (libcurl is already built with `-fPIC`.) BoringSSL remains built and linked as shared library in GHA/http3-linux. Follow-up to 39c8f9d #23179 Closes #23177
As interface lookups are case-sensitive, peer compare must also treat those strings as such. Add tests. reported-by: Joshua Rogers Closes #23164
Since a callback might unregister itself in a call, check the presence of the notify callback every time when looping of the events to dispatch. Removing the callback during dispatch will then simply clear all notification chunks. reported-by: Joshua Rogers Closes #23167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )