Repository navigation
[pull] master from curl:master - #1662
Merged
Merged
Conversation
Homebrew libssh2 1.11.1_6 revision backported a patch which disabled legacy algorithms by default, without re-enabling them manually. This effectively disabled MD5, breaking runtests relying on it. Fix by disabling these tests when using Homebrew libssh2. Fixing, in 'CM address-sanitizer H3 c-ares' CI job: ``` FAIL 664: 'SFTP correct host key' SFTP, server key check FAIL 665: 'SCP correct host key' SCP, server key check FAIL 2007: 'SFTP quote rmdir command with trailing junk' SFTP, --quote ``` Ref: https://github.com/curl/curl/actions/runs/36691471709/job/109812874116#step:50:4471 Refs: https://github.com/libssh2/libssh2/commit/b89858b83d68d7e29e0c5b0bb803f8a68271710c.patch Homebrew/homebrew-core@ebe712b Homebrew/homebrew-core#311239 Bug: #23181 (comment) Closes #23182
pyrefly does not tend to "break" Python code, thus remove the pin and let it auto-update via Linuxbrew to avoid the disuption of manual version bumps. Assisted-by: Dan Fandrich Ref: #23152 (comment) Follow-up to 5c58f89 #23152 Closes #23180
Each `install:` combination results in a separate (and fairly large) cache entry. There are ~12 of them before this commit, in the 100-200 MB size range each. Reduce the number of cache entries by installing commonly used packages for all jobs. But, each installed package comes with a size overhead in the cache entry and a significant time to install them, even if unused in an actual job (because the cache holds the raw package tarballs, which still need to be installed in each job run). Thus, keep the list of commonly used packages minimal, and install the rest of the packages in an separate `pacman` step, without using the cache. These packages include the build tools (autotools, cmake), and extra, not commonly used packages that a job may need in addition. This reduces the number of cache blobs to 4, one per MSYS2 environment, while a slight, tolerable rise in install times. Since some packages are now installed, but not intended to be used, we need to make sure auto-detections don't pick them up. (existing configs already complied with this.) Also: - update logic that relied on the per-package `install:` list to decide which SSH backend is used. Use the `config:` line instead. - tried installing builds tools in the default install list. This turned out to cause much overhead in wasted size and install time. All in all, this balancing act is painful and difficult to maintain, I wish the MSYS2 Action would cache the _installed_ directory, thus avoiding the lengthy install step for installed/cached packages. This would allow to install everything from cache with good performance, still save bandwidth and server load for MSYS2, while simplifying things. Pending upstream issue about such feature: msys2/setup-msys2#575 Slight downside is that mutually exclusive packages cannot be installed, namely libssh2 vs. libssh2-wincng. Not currently used. In the future (once the WinCNG stabilizing fix reaches a release) the variants can be spread across envs to cover both without adding new cache blobs: ```diff -mingw-w64-${{ matrix.env }}-libssh2 +${{ matrix.env == 'ucrt-x86_64' && format('mingw-w64-{0}-libssh2-wincng', matrix.env) || format('mingw-w64-{0}-libssh2', matrix.env) }} ``` Follow-up to 66313cc #16629 Closes #23155
No release in 6 months, no commit in 5 months. Lots of debt and a matching number of local workarounds. Ref: https://github.com/rhysd/actionlint Follow-up to 60dd72b #19373 Closes #23194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )