Repository navigation
feat(comfy): ingest completed local outputs into linked folders and copy pipelines - #438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComfyUI monitoring previously updated queue state while library ingestion depended on filesystem notifications. This adds an optional, session-scoped output mapping: persisted image events index named files in a registered linked folder or harvest them through an enabled copy-only pipeline, then refresh the gallery through the existing library event.
The native path processes at most 64 descriptors per frame without walking the output tree. It rejects unsafe paths, overlapping/linked destinations, paused/move pipelines and orphan sidecars; identical duplicates do not refresh, and different-byte collisions preserve both files and report failure. Exclusive copy creation closes the check/copy overwrite race in ordinary pipeline publication and managed imports, retaining source permissions. This completion path never schedules cleanup or invokes Trash. The selector and hints cover all seven locales.
Adds the optional
outputFolderIdargument to the existing monitor command; omission retains monitoring-only behavior. No schema, configuration field or event DTO changes. Also reconciles the published v0.6.0 receipt and records these changes under Unreleased.Validation
cargo fmt --checkand strict workspace clippy passed.cargo test --offline --workspace: 434 passed, zero failed, two existing tests ignored.Remaining acceptance
Remote transfer, reconnect/history catch-up, move/cleanup and a separate ingestion worker remain outside this PR. Legacy pipeline fallback still visits top-level files only, so disconnected nested outputs are not recovered by this package. Unix permission/symlink fixtures require Unix CI. Real personal ComfyUI, native GUI and installed-update/Sandbox acceptance were not exercised; #256 remains open.
Preserve the 11 small commits when merging into
dev; do not squash or targetmain.