Repository navigation
Feat/add teams channel plugin - #96
Merged
arefbehboudi merged 7 commits intoOct 31, 2026
Merged
Conversation
arefbehboudi
self-requested a review
October 8, 2026 12:23
arefbehboudi
requested changes
Oct 8, 2026
arefbehboudi
left a comment
arefbehboudi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this, the overall structure follows the other plugins nicely, and the JWT validation and tests are good to see. I ran :plugins:teams:test (all passing) and booted the app. Three things need to change before merge: the committed default config, the open-by-default user check, and reply routing to the wrong conversation. The rest are should-fix or nits. Also, most of the new files are missing a trailing newline.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bsjwgb1YHouoDYHkhrHFN4
- Reply to the conversation each message came from instead of the last one - Reject all messages when no allowed user is configured, and ask for it in onboarding - Match the allowed user against the Entra object ID as well as the Teams user ID - Verify JWT claims with Nimbus (5 min clock skew) and check the serviceUrl claim - Ignore messages without a conversation id and prefix agent conversation ids with teams- - Stop logging message content, remove the duplicate webhook controller bean - Move the nimbus-jose-jwt version to the version catalog, add trailing newlines Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bsjwgb1YHouoDYHkhrHFN4
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Bsjwgb1YHouoDYHkhrHFN4
arefbehboudi
approved these changes
Oct 31, 2026
arefbehboudi
left a comment
arefbehboudi
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @AlirezaValikhani , great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80