Repository navigation
Conversation
Component.mask now redacts any present, non-empty value after String() coercion, and Component.maskFields replaces BaseRegistry.maskSensitiveFields, Trigger.maskFields and the hand-rolled Docr and Ecr copies.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
scttbnsn
added a commit
that referenced
this pull request
Oct 20, 2026
scttbnsn
added a commit
that referenced
this pull request
Oct 20, 2026
* refactor(app): share error, sleep and status helpers (#1423) * refactor(component): share one secret-mask helper (#1414) * feat(api): name the caller behind removed-API hits (#1402) * refactor(ui): share the search-from-query logic (#1418) * refactor(ui): seed the operations store from the container list (#1428) * build(docker): use Alpine's patched zlib and drop the custom build (#1417) * chore(license): relicense from AGPL-3.0 to MIT (#1410) * docs(changelog): one heading per section in Unreleased
Contributor
Author
|
Landed in #1434 as part of folding the reviewed 1.8 work into 1.8.0. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DR-15. One secret-mask helper on the shared
Componentbase. Held for 1.8.1.Component.mask(value: unknown)returns[REDACTED]for any value that is present and non-empty afterString()coercion, andundefinedfor null, undefined and''. Numbers (0 included), booleans, objects, non-empty arrays and whitespace strings are all masked. New instance methodComponent.maskFields(fields)returns a copy of the configuration with those flat fields masked.Removed:
BaseRegistry.maskSensitiveFields,Trigger.maskFields, and the hand-rolled copies in Docr and Ecr. No aliases left.Call sites, 50 total:
maskFields([...])calls: 14 registry providers (acr, alicr, custom, dhi, gar, gcr, ghcr, gitlab, hub, ibmcr, mau, ocir, quay, SelfHostedBasic), Docr and Ecr (previously hand-rolled), and 15 trigger providers (apprise, discord, googlechat, gotify, ifttt, matrix, mattermost, mqtt, portainer, pushover, slack, smtp, teams, telegram)Component.mask()calls for nested secrets: Agent, Basic, Oidc, Http, Kafka, Ntfy, Rocketchat, Docker watcher (call sites unchanged, new coercion rules)Visible changes:
0andfalseare now redacted.undefinedkeys for unset secret fields (invisible in JSON).[REDACTED]everywhere already, so no format change.Tests: table test for
maskandmaskFieldsinComponent.test.ts. Existing maskConfiguration tests pass unchanged. Targeted run of registries, triggers, registry, agent, authentications and watchers: 222 files, 9116 passed. Push gate green including coverage.