Repository navigation
Conversation
Notification triggers now remember the last skip reason per container (rule-disabled, threshold-not-met, trigger-excluded, once-already-sent, recently-applied, digest-buffered) instead of leaving it in a DEBUG log line. The reason clears when a notification is sent and the store is capped at 1000 entries. It shows in the debug dump, on the container detail and triggers API responses, and in the container detail Actions tab.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
scttbnsn
added a commit
that referenced
this pull request
Oct 20, 2026
scttbnsn
added a commit
that referenced
this pull request
Oct 20, 2026
* fix(agent): detect half-open agent event streams (#1405) * fix(compose): fill the operation record like the Docker action (#1406) * fix(watcher): don't hold update results for release notes (#1409) * perf(store): use the stats projection for counts (#1411) * fix(store): keep a retained policy with the replacement on local renames (#1412) * fix(api): build the dependency graph from the listed containers (#1419) * fix(agent): tell Portwing timeouts apart from unreachable agents (#1422) * feat(api): include versions in update-operation-changed events (#1427) * feat(notifications): show why a notification was skipped (#1429) * docs(changelog): sort the batch B entries into their sections
Contributor
Author
|
Landed in #1433 as part of folding the reviewed 1.8 work into 1.8.0. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the last skip reason per notification trigger and container, so a missing notification can be explained without DEBUG logging (DR-85, from #302).
Reasons: rule-disabled, threshold-not-met, trigger-excluded, once-already-sent, recently-applied, digest-buffered. They show in the container detail Actions tab, as notificationSkips on GET /api/v1/containers/{id} and /triggers, and in the debug dump. In memory only, capped at 1000, cleared on send.
Held for 1.8.1.