Repository navigation
Conversation
…ntent-Type says gzip
yetval
force-pushed
the
fix/gzip-magic-bytes-only
branch
from
November 9, 2026 17:37
9f050b8 to
e7c7bfd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where
SitemapSpider,XMLFeedSpider, andCSVFeedSpiderincorrectly attempt to decompress responses that are already plain XML or CSV.Problem
Currently,
_decompressrelies on theContent-Typeheader to determine whether a response is gzipped. If the server incorrectly labels plain content as gzip, this causes a decompression error and prevents URLs from being extracted.For example, Dell's sitemap returned 0 out of 3,030 URLs because its plain XML was labeled as
application/x-gzip.Fix
Updated
_decompressto check for the actual gzip magic bytes (1f 8b) instead of relying on theContent-Typeheader. Existing gzip-bomb protection and invalid gzip handling remain unchanged.Testing