Repository navigation
Updates for FFE and sum_pixel_signals - #338
Merged
Merged
Conversation
`detector` assumes sim.FARFIELD_ENABLED is correct
Quick implementation of a box-aware lattice dipole approximation method to calculate the far field induced current. This method includes dipole images for the walls at X and Y in addition to the Z images across the cathode. The overall method is slightly different from the original infinite-plane method. Each method can be selected via a constant flag in `consts/ff_induction.py`. The lattice dipole has several new constants, the number of X/Y terms and the box half-widths (which should eventually use the geometry info for these numbers). Both methods have a normalization/scale factor, `DIPOLE_SCALE`, defined as a constant to adjust the signal strength. Validated that the code runs, not so much the results yet.
`detector` assumes sim.FARFIELD_ENABLED is correct
This reverts commit df67aca.
This reverts commit 2cb1772.
This reverts commit f51ff21.
Member
Author
|
I seem to be seeing some strange behavior when I run on the 2x2 with FFE disabled. Namely, the data packets are coming out with a |
mjkramer
marked this pull request as draft
October 8, 2026 16:45
Member
Author
mjkramer
marked this pull request as ready for review
October 9, 2026 21:42
cuddandr
reviewed
Oct 12, 2026
cuddandr
reviewed
Oct 13, 2026
Member
Author
Collaborator
|
Looks good to me. Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR updates
developto be in line with (but cleaner than) theffe-test3branch that I've been using for the FSD Cube shower simulations.Physics changes:
sum_pixel_signals, makeMAX_TRACKS_PER_PIXELlimit only the amount of saved backtracking info. Previously it also limited the number of segments included in the calculated signal. This fix primarily affects dense showers, whether or not FFE is enabled.FAR_FIELD_SEGMENT_STEP_CMto 0.1 cm from 0.5 cm. (We can almost certainly raise it back, but TBD.)exclude_radiusorthat should have been anandin theexclude_radiuscutOrganizational changes:
ff_inductionconstants using afarfield_propertiesyamlff_induction.DIPOLE_SCALEconstant (the notorious 1.5)FARFIELD_MODEfrom thesimulation_propertiesto thefarfield_properties. The global switch,FARFIELD_ENABLEDstill lives insimulation_properties.ffe-test3, not fromdevelop) thebox_latticeandpatch(i.e. "near-field") FFE models. The original infinite-plane (i.e. "dipole") model seems to be good enough, but the alternatives can be recovered by reverting the commit that removed them.FARFIELD_SIGNAL_MODELconstant. Currentlyinfinite_planeis the only option, but I figured this bit of configurability was worth keeping.fsd_cubeconfig. It can be disabled by changingSIMULATION_PROPERTIESback tocosmic_sim.yamlfromcosmic_sim_FFE.yaml. FFE remains disabled by default for other detectors.