Repository navigation
Set FSD Cube ADC busy delay to 8 ticks - #342
Merged
Merged
Conversation
Member
|
Looks good to me! We discussed updating the default value in detector.py, which we will do once validated against 2x2 data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
adc_busy_delay: 8inlarndsim/detector_properties/fsd_cube.yaml, overriding the inherited value of 9.ADC_BUSY_DELAY is set to 8 instead of 9 to account for the busy delay physically happening in parallel with the 1 tick reset while larndsim models the reset and busy delay as happening sequentially.
The same explanation is included as a YAML comment. This change applies to the FSD Cube detector configuration.