Repository navigation
(#1031) Tests: wait for native Windows process termination - #1034
Open
pkazakov-dev wants to merge 3 commits into
Open
pkazakov-dev wants to merge 3 commits into
pkazakov-dev wants to merge 3 commits into
Conversation
WaitForExitAsync can observe an exit code through HasExited before the native Windows process handle is signaled. Wait for native termination before disposing the job object and allowing callers to delete test files, while retaining explicit command disposal. Extract the shared exit wait and add a Windows regression test using modern .NET child processes with many open native handles to expose the exit-code/termination window. Validation: all three Cesium.TestFramework.Tests tests pass on .NET 10.0.14 with SDK 10.0.403. The regression assertion failed before adding the native wait.
kant2002
reviewed
Nov 5, 2026
| public class ExecUtilTests(ITestOutputHelper output) | ||
| { | ||
| [WindowsFact] | ||
| public async Task ProcessHasTerminatedWhenExitWaitCompletes() |
Collaborator
There was a problem hiding this comment.
Do we need tests for tests? Sounds fragile
Owner
There was a problem hiding this comment.
Generally, I am ok with having tests for test framework, and we actually write them.
Contributor
Author
There was a problem hiding this comment.
Ok, the question is then:
is this test needed in our suite?
I understand this test target specific regression as of now, but do we want to test this behavior?
pkazakov-dev
marked this pull request as ready for review
November 6, 2026 06:44
ForNeVeR
self-requested a review
November 6, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WaitForExitAsync can observe an exit code through HasExited before the native Windows process handle is signaled. Wait for native termination before disposing the job object and allowing callers to delete test files, while retaining explicit command disposal.
Aims to close #1031