Repository navigation
Conversation
pkazakov-dev
marked this pull request as ready for review
November 10, 2026 07:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to fix #1033
The failure came from mixing incompatible versions of build libraries.
Previously, NUKE loaded the project inside its own process. With the newer .NET SDK, project evaluation needed a newer NuGet.Frameworks library, but NUKE already had an older version loaded. That caused an exception before publishing started.
The fix runs project evaluation through dotnet msbuild in a separate process. MSBuild uses the libraries supplied with the selected SDK and returns the results as JSON. NUKE reads those results without loading the SDK’s libraries itself.
The property list specifies which values the build script needs: the project version, project location, and output directories. MSBuild calculates these values using the project’s settings, including Debug or Release configuration.
We could request each property separately. Listing them together gets everything in one call, and the helper method keeps that logic in one place.
Finally, latestFeature allows a newer installed .NET 10 SDK to be selected. The evaluation change removes the incompatibility that previously prevented using it.