Repository navigation
Box, Position: Fix validation of shade_offset and refpoint - #4963
Merged
seisman merged 3 commits intoOct 25, 2026
Merged
Conversation
Member
|
@tashakaggarwal Thanks for your contributions. It seems this PR contains the commit 5ef9f4e, which is not relevant to this PR. Please discard that commit first. |
This reverts commit 5ef9f4e.
Contributor
Author
|
@seisman commit discarded |
seisman
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Two validation bugs in the new
pygmt.paramsclasses:Box(shade_offset=np.array([1, 2]))raisesValueError: The truth value of an array with more than one element is ambiguous, becauseshade_offsetis tested with plain truthiness(
if self.shade_offset and ...,self.shade_offset or []). The same truthiness test makesBox(shade_offset=[])silently ignored rather than rejected as "not a sequence of two values".Now uses
is not None.Position(["T", "L"], cstype="inside")(or"outside") raisesTypeError: unhashable type: 'list'from thein _valid_anchorsset lookup, instead of the intendedGMTValueError. Nowchecks
isinstance(refpoint, str)first.Tests added for both.