Repository navigation
refactor(companion): modularize nonce registration and error response sealing in ChallengeHandler - #49
Merged
HMAKT99 merged 1 commit intoNov 1, 2026
Conversation
…rror sealing in ChallengeHandler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
ChallengeHandler.handleChallenge(encryptedData:deviceID:), nonce tracking cache management, biometric prompt dispatching, and error wire formatting were inline within a single asynchronous block.This refactoring extracts three focused helpers:
registerNonceIfFresh(nonce:expiry:): Prunes expired nonces, ensures replay prevention under the 512-entry bounds, and commits fresh challenge nonces.performAuthentication(reason:): Cleanly encapsulates routing between injected test closures andLocalAuthManager.sendErrorResponse(code:description:challengeID:session:): Encapsulates error payload packaging and wire sealing underWireFormat.seal(.error, ...).All authorization validation, token generations, cancellation semantics, Secure Enclave flows, and error responses remain identical.
Testing
xcodebuild test -project companion/TouchBridge.xcodeproj -scheme TouchBridge: 10 companion security tests pass on the iOS Simulator.