Skip to content

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point - #173

Merged
evetion merged 3 commits into
mainfrom
as/point_geom
Oct 23, 2026
Merged

evetion merged 3 commits into
mainfrom
as/point_geom

Conversation

@asinghvi17

Copy link
Copy Markdown
Member

This was mentioned on Slack, the output is probably a bit better than a method ambiguity error now.

@rafaqz

rafaqz commented Oct 24, 2024 •

Copy link
Copy Markdown
Member

Not sure nothing is the best return value here.

We could also just return the point from getgeom and ngeom could be 1

Or error

@asinghvi17

Copy link
Copy Markdown
Member Author

Error might be best?

@rafaqz

rafaqz commented Oct 31, 2024

Copy link
Copy Markdown
Member

Error is pretty safe as we can always change it later, but returning nothing is permanent

@rafaqz

rafaqz commented Dec 13, 2024 •

Copy link
Copy Markdown
Member

Maybe GI.getgeom(point, 1) should return the point? a bit like how numbers work just returning themselves?

Then GI.ngeom(point) should return 1

@asinghvi17

Copy link
Copy Markdown
Member Author

Eh that sounds too recursive for my liking...let's just error

@rafaqz

rafaqz commented Nov 8, 2025

Copy link
Copy Markdown
Member

Where is this one at?

Comment thread src/wrappers.jl Resolved
evetion and others added 2 commits October 22, 2026 21:12
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
@asinghvi17

Copy link
Copy Markdown
Member Author

Thanks for the update @evetion, lgtm I guess :D

@evetion
evetion merged commit 1920dee into main Oct 23, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants