Skip to content

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evetion merged 3 commits into from
Oct 23, 2026
Merged

Remove ambiguity and implement getgeom, ngeom for Wrappers.Point #173

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7a4a1e
Remove ambiguity and implement `getgeom`, `ngeom` for `Wrappers.Point`
asinghvi17 Oct 23, 2024
a83406c
Update src/wrappers.jl
evetion Oct 22, 2026
03ee99b
Merge branch 'main' into as/point_geom
evetion Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/wrappers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,10 @@ convert(::Type{Point}, ::PointTrait, geom) = Point(geom)
convert(::Type{Point}, ::PointTrait, geom::Point) = geom
extent(trait::PointTrait, geom::Point) = extent(trait, parent(geom))

ngeom(::PointTrait, geom::Point) = 0
getgeom(::PointTrait, geom::Point) = nothing
getgeom(::PointTrait, geom::Point, i) = nothing
Comment thread
evetion marked this conversation as resolved.
Resolved

x(trait::PointTrait, geom::Point) = x(trait, parent(geom))
y(trait::PointTrait, geom::Point) = y(trait, parent(geom))
z(trait::PointTrait, geom::Point{true}) = z(trait, parent(geom))
Expand Down