Repository navigation
Allow CEnum 1.0 - #660
Merged
Merged
Allow CEnum 1.0#660
Conversation
CEnum 1.0 is compatible with how we use it: the generated `@cenum` declarations evaluate identically, and the only semantic change (shifts on Cenum values no longer widen) isn't used here. Older 0.x versions are dropped; 0.5 has been the current release for years.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 56 56
Lines 6512 6512
=======================================
Hits 6157 6157
Misses 355 355 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widens the CEnum compat to
0.5, 1.CEnum 1.0 was tested against this package (and the rest of the JuliaGPU stack) with no failures attributable to it. All
@cenumdeclarations across the dependents evaluate to the same base type and members under 0.5 and 1.0. The one semantic change, shifts on Cenum values no longer widening to a larger integer type, is not used here. Older 0.x entries are dropped since 0.5 has been current for years.The resolver will only pick CEnum 1.0 once every package in an environment allows it, so this can be merged independently of the other packages.