Repository navigation
Conversation
Cisco's MLS (RFC 9420) implementation in C++, at the commit Discord's libdave pins, built the way libdave's vcpkg port builds it. libdave_jll will follow once this is registered.
manelsen
added a commit
to manelsen/Accord.jl
that referenced
this pull request
Nov 1, 2026
Yggdrasil allows one package per recipe, so mlspp gets its own recipe (shared libraries, configured like libdave's vcpkg port) and libdave depends on mlspp_jll. Neither needs patches anymore. The mlspp recipe is submitted as JuliaPackaging/Yggdrasil#15399; libdave follows once mlspp_jll is registered.
lgoettgens
reviewed
Nov 2, 2026
|
|
||
| sources = [ | ||
| GitSource("https://github.com/cisco/mlspp.git", | ||
| "1cc50a124a3bc4e143a787ec934280dc70c1034d"), |
| dependencies = [ | ||
| Dependency("OpenSSL_jll"; | ||
| compat="3.0.16"), | ||
| BuildDependency("nlohmann_json_jll"), |
Member
There was a problem hiding this comment.
you probably want to fix a version of this build dependency
manelsen
force-pushed
the
mlspp-v0.1.1
branch
from
November 2, 2026 19:45
e878ec3 to
286cbfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mlspp, Cisco's C++ implementation of MLS (RFC 9420). It is the first of two PRs: the second adds Discord's libdave (the DAVE end-to-end encryption that Discord now requires for voice), which links against it. This follows up on #14291, which built mlspp inside the libdave recipe; splitting it out answers the review question there about building another library in the same recipe.
Choices worth a look:
1cc50a1, the commit libdave pins in its vcpkg overlay port, which is 210 commits after v0.1.0, so the JLL isv0.1.1.MLS_CXX_NAMESPACE=mlspp(libdave's sources refer tomlspp::directly) andDISABLE_GREASE=ON.'get<…>' is unavailable: introduced in macOS 10.14inlib/hpke/src/certificate.cpp. aarch64 builds without it.CompilerSupportLibraries_jll1.1.2.libmls_dsandlibmls_vectorsare also installed; they are not declared as products since libdave does not use them.Tested locally with the repository's
.ci/bb1_project(Julia 1.13.2) for x86_64-linux-gnu, riscv64-linux-gnu, x86_64-w64-mingw32, x86_64-apple-darwin, aarch64-apple-darwin and x86_64-unknown-freebsd. libdave v1.2.2 built against the x86_64-linux-gnu shared libraries passes the DAVE test suite of Accord.jl, a Discord library that will be the first user of libdave_jll.