Skip to content

Remove deprecated unittest2 lib #77

Open

Description

@ClementWalter

I am following from this issue on poetry: python-poetry/poetry#3906

I guess that unittest2 is now deprecated and causes troubles for dependency resolution.
Interestingly enough I see that you are still using old fashioned requirements.txt (which is actually not consistent with a dup). If you would like to, I could upgrade your project to using poetry instead.

Activity

  1. FabianIsensee commented on Apr 14, 2021

    @FabianIsensee
    Member

    Hi Clement,
    thank you for pointing this out. We would like to have additional dependencies, especially ones that we are not familiar with.
    I agree that we should not be using requirements.txt anymore. Batchgenerators has a long history of 'do not touch a running system' :-). I will update it to use a regular setup.py shortly. Is there a low-tech way of fxing the unittest2 problem?
    Best,
    Fabian

  2. ClementWalter commented on Apr 14, 2021

    @ClementWalter
    Author

    Actually poetry is not a dependency but a dependency management system. Currently you have deps defined in setup, in requirements, they do not math and are not locking any deps of your project (deps of deps for instance).

    I am going to create another PR to show you how it would be

  3. dyollb commented on Nov 26, 2024

    @dyollb

    the dependency unittest2 should be optional (or upgraded to simply use unittest).

    This can be achieved without poetry, e.g. using standard setuptools. I am happy to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions