Repository navigation
Fix the README quick-start and GPU instructions - #461
Merged
Merged
Conversation
…s APIs `NonhydrostaticModel(; grid, ...)` and `NutrientPhytoplanktonZooplanktonDetritus(; grid)` don't exist in any supported version, so the quick-start errored. Use `NonhydrostaticModel(grid; ...)` and `NPZD(grid)`, as in the documentation's quick-start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`GPU()` is defined by Oceananigans' CUDA extension, so CUDA has to be loaded. The GPU grid also still had the size and extent the quick-start used before 150d55c, which puts the front outside the domain, rather than the quick-start's grid with `CPU()` swapped for `GPU()` as the text says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NPZD(grid)andNonhydrostaticModel(grid; ...)in the quick-start, as in the docs.NutrientPhytoplanktonZooplanktonDetritus(; grid)andNonhydrostaticModel(; grid, ...)don't exist in any supported version, so the quick-start errored.GPU()is defined by Oceananigans' CUDA extension) and use the quick-start's grid there, as the text says (the old size and extent put the front outside the domain). This is a separate commit.The quick-start runs on Oceananigans 0.115.0 and 0.116.1 (including the visualization), and the GPU version runs on a GPU.
🤖 Generated with Claude Code