Repository navigation
Update the sugar kelp test to the current API and run it in CI - #462
Merged
Merged
Conversation
`test_sugar_kelp.jl` still passed the pre-NutrientsPlanktonDetritus `carbonates`, `variable_redfield`, `oxygen = true`, and `sinking_speeds` keyword arguments to `LOBSTER` and read the Redfield ratios off the struct, so it errored. It was also never run because `runtests.jl` only had a commented-out include of its old name, `test_slatissima.jl`. The test now builds LOBSTER with `CarbonateSystem()`, `CarbonNitrogenDissolvedParticulate` and `Oxygen()` (the tracers the kelp couples to), sums the nitrogen and carbon in the tracers with `conserved_tracers`, and is included in `runtests.jl`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sugar_kelp.jlpassed keyword arguments thatLOBSTERno longer accepts (carbonates,variable_redfield,oxygen = true,sinking_speeds) and read Redfield ratios off the old struct, so it errored. It never ran in CI becauseruntests.jlonly had a commented-out include under its old name,test_slatissima.jl.CarbonateSystem(),CarbonNitrogenDissolvedParticulate(grid)andOxygen(), which provide the tracers the kelp couples to.conserved_tracers.runtests.jl.The full test suite passes on CPU and GPU with Oceananigans 0.115.0, and the test also passes on CPU with 0.116.1.
The tolerances are unchanged, but the carbon tolerance (~1.5e-3 mmol C) is ~80× the carbon the kelp exchanges with the tracers in this test (~1.9e-5 mmol C), so it can't catch a sign error in the carbon coupling. Tightening it is left for a follow-up.
🤖 Generated with Claude Code