Skip to content

feat(ecosystem): send GameCube and Wii games to iCube via the drop box - #3819

Merged
JoeMatt merged 2 commits into
developfrom
feature/ecosystem-handoff-sender
Nov 17, 2026
Merged

JoeMatt merged 2 commits into
developfrom
feature/ecosystem-handoff-sender

Conversation

@JoeMatt

@JoeMatt JoeMatt commented Nov 17, 2026

Copy link
Copy Markdown
Member

What does this PR do

Provenance's sending half of the cross-app App Group drop box (contract v1, shared with iFly and iCube). A GameCube or Wii game in the library can be handed straight to iCube without the share sheet. The receiving half landed in bb54d8a.

  • EcosystemHandoffStager (new, ported from iFly): clones the files into Handoff/<peer>/.<id>.staging/, writes manifest.json, then renames the folder to <id>. A failed stage removes the staging folder. It also removes Provenance's own hand-offs nobody took within 7 days and staging folders older than an hour.
  • EcosystemHandoffSender (new): maps .GameCube / .Wii to iCube's gamecube / wii. It offers a direct route only when iCube is installed, its Apps/dolphinios.json takes a game for that system, and the library file is a disc image iCube imports (iso gcm tgc wbfs gcz ciso rvz wad dol elf nkit wia img bin; not archives or .m3u).
  • Game context menu (shared by iOS and tvOS): shows Send to iCube only when that route exists; otherwise the menu is unchanged. Provenance has no per-game share sheet, so there is no fallback row. After staging it opens dolphinios://handoff?id=…&from=provenance. If iCube can't be opened, a toast says the game is waiting for iCube.
  • Clean-up runs in EcosystemHandoffReceiver.appBecameActive(), after receiving.
  • Info.plists: dolphinios was missing from LSApplicationQueriesSchemes in the Lite and UnderDevelopment iOS plists (which the tvOS build also uses) and in both ProvenanceTV-* plists. Without it canOpenURL("dolphinios://") is always false there.

Where should the reviewer start

PVLibrary/Sources/PVLibrary/Importer/Services/EcosystemIntegration/EcosystemHandoffSender.swift, then EcosystemHandoffStager.swift, then PVUI/Sources/PVUIBase/Game/EcosystemHandoffSendAction.swift.

How should this be manually tested

On a device with iCube (a build with iCube's PR 111, Provenance-Emu/iCube#111) and Provenance both installed and signed into the App Group:

  1. Open iCube once so it writes its presence entry.
  2. In Provenance, long-press (iOS) or open the context menu (tvOS) on a GameCube or Wii game stored as a disc image. Send to iCube should appear; it should not appear for a zip or m3u game, or with iCube uninstalled.
  3. Tap it. iCube should open and import the game.

Any background context you want to provide

  • Contract unchanged; it is the header comment of iFly's EcosystemHandoff.swift.
  • Not covered: iFly (Dreamcast/NAOMI) would need its own target row, extension list and the NAOMI file layout. Saves and LAN sharing are out of scope.
  • Verified: the full PVLibrary-UnitTests suite (744 XCTest + 131 Swift Testing, 0 failures), including 21 new EcosystemHandoffSenderTests run against a temp directory standing in for the group container. PVUI builds for the generic iOS Simulator and tvOS Simulator. swiftlint finds nothing on changed lines, and check_pbxproj_sources.py and plutil -lint are clean.
  • Not verified: any real transfer on a device (simulator builds are not in the App Group), the menu row on iOS or tvOS, and full app archive builds.

What are the relevant tickets

Provenance-Emu/iCube#111 (iCube's send/receive side).

Screenshots (important for UI changes)

None; one context-menu row ("Send to iCube", cube symbol).

Questions

None.

🤖 Generated with Claude Code

Only the two full iOS plists listed dolphinios in
LSApplicationQueriesSchemes, so canOpenURL("dolphinios://") was always
false in Lite, UnderDevelopment and the tvOS plists. Add it to each.
Provenance's sending half of the App Group drop box (contract v1).
EcosystemHandoffStager (ported from iFly) clones the files into
Handoff/<peer>/.<id>.staging, writes the manifest and renames it into
place; a failed stage removes the staging directory. It also removes
Provenance's own hand-offs nobody took within 7 days and staging
directories older than an hour, run on every activation after receiving.

EcosystemHandoffSender maps GameCube/Wii to iCube ("gamecube"/"wii")
and offers a direct route only when iCube is installed, its presence
takes a game for that system, and the library file is a disc image it
imports (no archives or .m3u). The game context menu (iOS and tvOS)
shows "Send to iCube" only then; otherwise the menu is unchanged.
After staging it opens dolphinios://handoff?id=…&from=provenance and
tells the user the game is waiting if iCube cannot be opened.
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T09:21:00.840088Z fc8a80d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@JoeMatt
JoeMatt merged commit e410df8 into develop Nov 17, 2026
21 of 23 checks passed
@JoeMatt
JoeMatt deleted the feature/ecosystem-handoff-sender branch November 17, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant