Repository navigation
feat(ecosystem): send GameCube and Wii games to iCube via the drop box - #3819
Merged
Merged
Conversation
Only the two full iOS plists listed dolphinios in
LSApplicationQueriesSchemes, so canOpenURL("dolphinios://") was always
false in Lite, UnderDevelopment and the tvOS plists. Add it to each.
Provenance's sending half of the App Group drop box (contract v1).
EcosystemHandoffStager (ported from iFly) clones the files into
Handoff/<peer>/.<id>.staging, writes the manifest and renames it into
place; a failed stage removes the staging directory. It also removes
Provenance's own hand-offs nobody took within 7 days and staging
directories older than an hour, run on every activation after receiving.
EcosystemHandoffSender maps GameCube/Wii to iCube ("gamecube"/"wii")
and offers a direct route only when iCube is installed, its presence
takes a game for that system, and the library file is a disc image it
imports (no archives or .m3u). The game context menu (iOS and tvOS)
shows "Send to iCube" only then; otherwise the menu is unchanged.
After staging it opens dolphinios://handoff?id=…&from=provenance and
tells the user the game is waiting if iCube cannot be opened.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Provenance's sending half of the cross-app App Group drop box (contract v1, shared with iFly and iCube). A GameCube or Wii game in the library can be handed straight to iCube without the share sheet. The receiving half landed in bb54d8a.
EcosystemHandoffStager(new, ported from iFly): clones the files intoHandoff/<peer>/.<id>.staging/, writesmanifest.json, then renames the folder to<id>. A failed stage removes the staging folder. It also removes Provenance's own hand-offs nobody took within 7 days and staging folders older than an hour.EcosystemHandoffSender(new): maps.GameCube/.Wiito iCube'sgamecube/wii. It offers a direct route only when iCube is installed, itsApps/dolphinios.jsontakes agamefor that system, and the library file is a disc image iCube imports (iso gcm tgc wbfs gcz ciso rvz wad dol elf nkit wia img bin; not archives or.m3u).dolphinios://handoff?id=…&from=provenance. If iCube can't be opened, a toast says the game is waiting for iCube.EcosystemHandoffReceiver.appBecameActive(), after receiving.dolphinioswas missing fromLSApplicationQueriesSchemesin the Lite and UnderDevelopment iOS plists (which the tvOS build also uses) and in bothProvenanceTV-*plists. Without itcanOpenURL("dolphinios://")is always false there.Where should the reviewer start
PVLibrary/Sources/PVLibrary/Importer/Services/EcosystemIntegration/EcosystemHandoffSender.swift, thenEcosystemHandoffStager.swift, thenPVUI/Sources/PVUIBase/Game/EcosystemHandoffSendAction.swift.How should this be manually tested
On a device with iCube (a build with iCube's PR 111, Provenance-Emu/iCube#111) and Provenance both installed and signed into the App Group:
Any background context you want to provide
EcosystemHandoff.swift.EcosystemHandoffSenderTestsrun against a temp directory standing in for the group container. PVUI builds for the generic iOS Simulator and tvOS Simulator. swiftlint finds nothing on changed lines, andcheck_pbxproj_sources.pyandplutil -lintare clean.What are the relevant tickets
Provenance-Emu/iCube#111 (iCube's send/receive side).
Screenshots (important for UI changes)
None; one context-menu row ("Send to iCube",
cubesymbol).Questions
None.
🤖 Generated with Claude Code