Repository navigation
Empty the Recycle Bin in a detached background process #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohamadsm313m-prog
wants to merge
1
commit into
QL-Win:master
Choose a base branch
from
mohamadsm313m-prog:fix/background-recycle-bin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the completion refresh's Recycle Bin query off the UI thread.
The completion callback dispatches to the UI thread and calls
UpdateState()there.UpdateState()callsRecycleBinHelper.GetRecycleBinInfo()synchronously, which runsSHQueryRecycleBin(null, ...)on the UI thread. The startup-failure branch also callsUpdateState()on the UI thread.A large Recycle Bin can make this query slow. One third-party report on Windows 10.0.26100 measured about 7.5 seconds for 3,378 items. The viewer can freeze for that duration if the helper exits while items remain in the bin.
Run
UpdateState()on the worker thread. It already dispatches its control updates, so the worker can call it directly. Dispatch the button re-enable separately so a query failure cannot leave the button disabled.Suggested fix
try { + try + { + // Query on the worker thread; UpdateState dispatches the control updates. + UpdateState(); + } + catch (Exception ex) + { + Debug.WriteLine(ex); + } Dispatcher?.BeginInvoke(new Action(() => { try { - UpdateState(); emptyButton.IsEnabled = true; } catch (Exception ex) { Debug.WriteLine(ex); } })); }