Add Symfony LSP diagnostics to CI

.github/workflows/build.yaml

@@ -41,6 +41,7 @@ jobs:
                     php-version: "${{ matrix.php-version }}"
                     extensions: "${{ env.PHP_EXTENSIONS }}"
                     coverage: "none"
+                    tools: "symfony"
 
             -   name: "Install composer dependencies"
                 uses: "ramsey/composer-install@v3"
@@ -65,6 +66,9 @@ jobs:
             -   name: "Lint twig files"
                 run: "(cd tests/Application && bin/console lint:twig ../../src/Resources)"
 
+            -   name: "Symfony diagnostics"
+                run: "symfony lsp:check --format=github"
+
     dependency-analysis:
         name: "Dependency Analysis (PHP${{ matrix.php-version }} | Deps: ${{ matrix.dependencies }} | SF${{ matrix.symfony }})"
 

.gitignore

@@ -8,6 +8,9 @@
 /.phpunit.cache/
 /.phpunit.result.cache
 
+# symfony lsp:check analyzes the repository root and caches in var/symfony-lsp
+/var/
+
 # Symfony CLI https://symfony.com/doc/current/setup/symfony_server.html#different-php-settings-per-project
 /.php-version
 /php.ini

.symfony-lsp.json

@@ -0,0 +1,8 @@
+{
+    "version": 1,
+    "projectRoots": [
+        "."
+    ],
+    "kernel": "Acme\\SyliusExamplePlugin\\Tests\\Application\\Kernel",
+    "translationDiagnostics": true
+}

CLAUDE.md

@@ -41,6 +41,7 @@ Based on the `composer.json` scripts section:
 - `composer check-style` - Check code style with ECS (Easy Coding Standard)
 - `composer fix-style` - Fix code style issues automatically with ECS
 - `composer phpunit` - Run PHPUnit tests
+- `symfony lsp:check` - Run Symfony-aware diagnostics (routes, services, templates, translations, config) against the plugin and its test application. Requires the Symfony CLI 5.20 or newer
 
 ### Static Analysis
 

tests/Application/config/packages/framework.yaml

@@ -1,9 +1,14 @@
+parameters:
+    # Adds a fallback APP_SECRET if the env var is not set, like DATABASE_URL in doctrine.yaml. symfony lsp:check
+    # analyzes the repository root and only loads a .env file from there, so it boots the kernel without
+    # tests/Application/.env
+    env(APP_SECRET): 'EDITME'
+
 framework:
     secret: '%env(APP_SECRET)%'
     ide: phpstorm
     form:
         enabled: true
-        legacy_error_messages: false
     csrf_protection: true
     session:
         handler_id: ~

tests/Application/config/packages/security.yaml

@@ -1,5 +1,4 @@
 security:
-    enable_authenticator_manager: true
     providers:
         sylius_admin_user_provider:
             id: sylius.admin_user_provider.email_or_name_based