Repository navigation
Remove the root node_modules symlink and point badges at 1.14.x - #96
Merged
Merged
Conversation
The shop and admin entries live in vendor/sylius/sylius, outside the test application, so webpack resolves the packages they import by walking up from vendor/ and never reaches tests/Application/node_modules. The root symlink put a node_modules on that path without the build configuration saying so. Tell webpack instead: resolve.modules keeps the normal lookup and falls back to the test application's node_modules, on both the shop and the admin config. Also ignore /node_modules without the trailing slash, so a recreated symlink is not committed again, and drop it from .gitattributes. Fixes #91
The README's Codecov and Stryker badges, and the Stryker badge Infection reports to, still used 1.12.x. That branch has been deleted, so the badges showed stale data, and 1.14.x reported its mutation score under the 1.12.x name.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.14.x #96 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2 2
===========================================
Files 2 2
Lines 16 16
===========================================
Hits 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91. This is the last maintained branch:
2.2.xwas done in #93, and1.12.xand2.0.xhave been deleted.Remove the root
node_modulessymlinkThe 1.x approach from #91:
tests/Application/webpack.config.jssetsresolve.moduleson both the shop and the admin config:['node_modules', path.resolve(__dirname, 'node_modules')], with a comment explaining why.vendor/sylius/sylius/…, so walking up from them never reachestests/Application/node_modules.node_moduleskeeps the normal lookup; the absolute path is the fallback the symlink used to provide.node_modulessymlink is deleted..gitignore:/node_modules/→/node_modules, so a recreated symlink stays ignored (checked withgit check-ignore)..gitattributes: dropped/node_modules.Verified
The 1.14.x CI doesn't build assets, so I checked by hand. I used a fresh clone in a directory with no
node_modulesin any parent: PHP 8.1,composer install, Node 20 (.nvmrc), Yarn 1.22.22, thenyarn install && yarn buildintests/Application.public/build"../../vendor/sylius/sylius/src/Sylius/Bundle/AdminBundle/Resources/private/entry.js" contains a reference to the file "semantic-ui-css/semantic.css"7f00c2c2…)Point the badges at 1.14.x
The README's Codecov and Stryker badges, and
logs.stryker.badgeininfection.json.dist, still used1.12.x. That branch is deleted, so the badges showed stale data, and 1.14.x reported its mutation score to Stryker under the1.12.xname. They now use1.14.x; Codecov already serves a badge for that branch.The Stryker badge for
1.14.xfills in after the first mutation-test run on the branch.