Repository navigation
Link the symfony-lsp issue from the APP_SECRET fallback - #97
Merged
Merged
Conversation
The fallback only exists because symfony-lsp loads .env from the analyzed root rather than the kernel's project dir. Point at the upstream issue, so it's clear when the fallback can be removed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.14.x #97 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 2 2
===========================================
Files 2 2
Lines 16 16
===========================================
Hits 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #87. The
env(APP_SECRET)fallback intests/Application/config/packages/framework.yamlonly exists because symfony-lsp loads.envfrom the analyzed root instead of the kernel's project dir. This links the comment to symfony/language-tools#120, so it's clear when the fallback can be removed. Comment-only change.