Repository navigation
[BUGFIX] Describe the commit-msg hook as reporting, not rejecting - #427
Merged
linawolf merged 1 commit intoOct 9, 2026
Conversation
The commit-msg hook of the TYPO3 Core (Build/git-hooks/commit-msg) prints an error box for a missing Resolves: line, an overlong line or a missing keyword, but then still adds the Change-Id and exits successfully: the commit is created anyway. The guide said the hook rejects such commits, which can make contributors rely on it instead of reading its output. Say that the hook reports and that its output must be read, point the two links that went to the pre-commit hook to the commit-msg hook, and name the commit-msg hook as the one adding the Change-Id. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Olivier Dobberkau <olivier.dobberkau@dkd.de>
froemken
approved these changes
Oct 3, 2026
froemken
left a comment
froemken
left a comment
Contributor
There was a problem hiding this comment.
Hi @dkd-dobberkau,
Thank you for this clarification.
Describing the actual behavior of the commit-msg hook is very helpful. Pointing out that it reports issues in the terminal without aborting the commit prevents contributors from overlooking required lines like Resolves:. Correcting the two cross-references to point to the commit-msg hook rather than the pre-commit hook is also a welcome fix.
The markup and line formatting are clean.
Best regards,
Stefan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit-msg hook of the TYPO3 Core (Build/git-hooks/commit-msg) prints
an error box for a missing Resolves: line, an overlong line or a missing
keyword, but then still adds the Change-Id and exits successfully: the
commit is created anyway. The guide said the hook rejects such commits,
which can make contributors rely on it instead of reading its output.
Say that the hook reports and that its output must be read, point the
two links that went to the pre-commit hook to the commit-msg hook, and
name the commit-msg hook as the one adding the Change-Id.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com
Signed-off-by: Olivier Dobberkau olivier.dobberkau@dkd.de