Skip to content

πŸ”— :: (#559) 지원 및 μž¬μ§€μ› μ‹€νŒ¨ μƒνƒœμ˜€λ₯˜ 문ꡬ κ°œμ„  - #560

Merged
ashxom merged 7 commits into
developfrom
bug/559-지원-및-μž¬μ§€μ›-μ‹€νŒ¨-μƒνƒœμ˜€λ₯˜-문ꡬ-κ°œμ„ 
Nov 18, 2026

Hidden character warning

The head ref may contain hidden characters: "bug/559-\uc9c0\uc6d0-\ubc0f-\uc7ac\uc9c0\uc6d0-\uc2e4\ud328-\uc0c1\ud0dc\uc624\ub958-\ubb38\uad6c-\uac1c\uc120"
Merged

ashxom merged 7 commits into
developfrom
bug/559-지원-및-μž¬μ§€μ›-μ‹€νŒ¨-μƒνƒœμ˜€λ₯˜-문ꡬ-κ°œμ„ 

Conversation

@ashxom

@ashxom ashxom commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

κ°œμš”

지원 및 μž¬μ§€μ› μ‹€νŒ¨ μ‹œ μ„œλ²„ 응닡에 λ§žλŠ” μ•ˆλ‚΄λ₯Ό μ œκ³΅ν•˜κ³  제좜 μƒνƒœλ₯Ό μ •μƒμ μœΌλ‘œ λ³΅κ΅¬ν–ˆμŠ΅λ‹ˆλ‹€.

μž‘μ—… λ‚΄μš©

  • λͺ¨μ§‘μ˜λ’°μ„œ μƒμ„Έμ˜ unapplicable_reason을 νŒŒμ‹±ν•΄ 지원 λΆˆκ°€ μ‚¬μœ  ν‘œμ‹œ
  • ν•™λ…„ μ œν•œ 응닡(403)을 μ˜¬λ°”λ₯΄κ²Œ 처리
  • 지원/μž¬μ§€μ›μ˜ 일반 μ‹€νŒ¨ μ‹œ 였λ₯˜ μ•ˆλ‚΄ 및 제좜 λ²„νŠΌ μƒνƒœ 볡ꡬ
  • 쀑볡 지원 및 μ§„ν–‰ 쀑인 지원에 λ§žλŠ” μ•ˆλ‚΄ 문ꡬ 적용
  • 링크만 μ²¨λΆ€ν•œ κ²½μš°μ—λ„ 지원 κ°€λŠ₯ν•˜λ„λ‘ μˆ˜μ •
  • 빈 URL μ²¨λΆ€λŠ” μš”μ²­μ—μ„œ μ œμ™Έ

ν•  말

μ—†μŒ

Summary by CodeRabbit

  • μƒˆ κΈ°λŠ₯

    • μ§€μ›μ„œμ— 파일 없이 URL μ²¨λΆ€λ§ŒμœΌλ‘œ 지원할 수 μžˆμŠ΅λ‹ˆλ‹€. 파일과 URL을 ν•¨κ»˜ μ²¨λΆ€ν•˜λŠ” 것도 κ°€λŠ₯ν•©λ‹ˆλ‹€.
    • 지원할 수 μ—†λŠ” λͺ¨μ§‘ κ³΅κ³ μ—λŠ” μ‚¬μœ κ°€ 제곡된 경우 ν•΄λ‹Ή μ‚¬μœ κ°€ ν‘œμ‹œλ©λ‹ˆλ‹€.
  • 버그 μˆ˜μ •

    • 지원 및 μž¬μ§€μ› μ‹€νŒ¨ μ‹œ 상황에 λ§žλŠ” μ•ˆλ‚΄ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ©λ‹ˆλ‹€.
    • 지원 학년이 λ§žμ§€ μ•Šκ±°λ‚˜ 이미 μ§€μ›ν–ˆκ±°λ‚˜ μ§„ν–‰ 쀑인 지원이 μžˆλŠ” 경우, μ•ˆλ‚΄ 문ꡬ가 상황에 맞게 ν‘œμ‹œλ©λ‹ˆλ‹€.

@ashxom ashxom self-assigned this Nov 18, 2026
@ashxom
ashxom requested a review from a team as a code owner November 18, 2026 13:36
@ashxom ashxom added the 버그 버그λ₯Ό μˆ˜μ •ν•©λ‹ˆλ‹€. label Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change β†’

No actionable comments were generated in the recent review.

Walkthrough

지원 제좜 νλ¦„μ—μ„œ URL만 μ²¨λΆ€ν•œ μš”μ²­κ³Ό νŒŒμΌμ„ μ²¨λΆ€ν•œ μš”μ²­μ„ μ²˜λ¦¬ν•©λ‹ˆλ‹€. 지원 및 μž¬μ§€μ› μ‹€νŒ¨ μ•ˆλ‚΄λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. λͺ¨μ§‘ 상세 μ‘λ‹΅μ˜ 지원 λΆˆκ°€ μ‚¬μœ λ₯Ό 화면에 ν‘œμ‹œν•©λ‹ˆλ‹€.

Changes: 지원 제좜 흐름

Layer / File(s) Summary
지원 μš”μ²­ ꡬ성과 제좜
feature/application/.../ApplicationViewModel.kt
URL이 ν•˜λ‚˜ 이상 있으면 제좜 λ²„νŠΌμ„ ν™œμ„±ν™”ν•˜κ³ , 곡백이 μ•„λ‹Œ URL만 μš”μ²­μ— ν¬ν•¨ν•©λ‹ˆλ‹€. 파일이 있으면 presigned URL 생성과 μ—…λ‘œλ“œλ₯Ό μˆ˜ν–‰ν•œ λ’€ 지원 μš”μ²­μ„ λ³΄λƒ…λ‹ˆλ‹€. μ‹€νŒ¨ μœ ν˜•μ— 따라 μ‚¬μ΄λ“œ μ΄νŽ™νŠΈλ₯Ό μ²˜λ¦¬ν•˜κ³ , 지원과 μž¬μ§€μ› μš”μ²­μ€ submitApplicationμ—μ„œ λΆ„κΈ°ν•©λ‹ˆλ‹€.
μ‹€νŒ¨ κ²°κ³Ό μ•ˆλ‚΄
feature/application/.../ApplicationScreen.kt, feature/application/.../strings.xml
지원 μ‹€νŒ¨μ™€ μž¬μ§€μ› μ‹€νŒ¨μ— 각각 였λ₯˜ ν† μŠ€νŠΈλ₯Ό ν‘œμ‹œν•©λ‹ˆλ‹€. 지원 좩돌 및 지원 κ°€λŠ₯ ν•™λ…„ μ•ˆλ‚΄ 문ꡬ도 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.

지원 λΆˆκ°€ μ‚¬μœ  ν‘œμ‹œ

Layer / File(s) Summary
지원 λΆˆκ°€ μ‚¬μœ  데이터 전달
core/network/.../FetchRecruitmentDetailsResponse.kt, core/domain/.../RecruitmentDetailsEntity.kt, feature/recruitment/.../RecruitmentDetailsViewModel.kt
μ‘λ‹΅μ˜ nullable unapplicableReason을 도메인 엔티티에 μ „λ‹¬ν•˜κ³ , κΈ°λ³Έ μ—”ν‹°ν‹°μ—λŠ” null을 μ„€μ •ν•©λ‹ˆλ‹€.
λͺ¨μ§‘ 상세에 μ‚¬μœ  ν‘œμ‹œ
feature/recruitment/.../RecruitmentDetailsScreen.kt
지원이 λΆˆκ°€ν•˜κ³  μ‚¬μœ κ°€ 곡백이 μ•„λ‹ˆλ©΄ μ‚¬μœ λ₯Ό ν‘œμ‹œν•©λ‹ˆλ‹€. μ‚¬μœ κ°€ μ—†κ±°λ‚˜ 곡백이면 κΈ°μ‘΄ κΈ°λ³Έ 문ꡬλ₯Ό ν‘œμ‹œν•©λ‹ˆλ‹€.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Applicant
  participant ApplicationScreen
  participant ApplicationViewModel
  participant PresignedURLUpload
  participant applyCompany/reApplyCompany
  Applicant->>ApplicationScreen: 지원 제좜
  ApplicationScreen->>ApplicationViewModel: 첨뢀 정보 전달
  alt 파일 첨뢀가 있음
    ApplicationViewModel->>PresignedURLUpload: presigned URL 생성 및 파일 μ—…λ‘œλ“œ
    PresignedURLUpload-->>ApplicationViewModel: μ—…λ‘œλ“œ κ²°κ³Ό
  end
  ApplicationViewModel->>applyCompany/reApplyCompany: URL 및 파일 μ²¨λΆ€λ‘œ 지원 μš”μ²­
  ApplicationViewModel-->>ApplicationScreen: 지원 μ‹€νŒ¨ μ‚¬μ΄λ“œ μ΄νŽ™νŠΈ
  ApplicationScreen-->>Applicant: μ‹€νŒ¨ ν† μŠ€νŠΈ ν‘œμ‹œ
Loading

Possibly related issues

  • 지원 및 μž¬μ§€μ› μ‹€νŒ¨ μƒνƒœμ˜€λ₯˜ 문ꡬ κ°œμ„ Β #559 β€” 지원 μ‹€νŒ¨ μ•ˆλ‚΄, 403 ν•™λ…„ 쑰건 μ•ˆλ‚΄, 지원 λΆˆκ°€ μ‚¬μœ  ν‘œμ‹œ, 링크만 μ²¨λΆ€ν•œ 지원 λ“± 이 PR의 λ³€κ²½ λ‚΄μš©κ³Ό 이슈 λͺ©ν‘œκ°€ κ²ΉμΉ©λ‹ˆλ‹€. μž¬μ§€μ› ν™”λ©΄μ˜ κΈ°μ‘΄ 첨뢀 정보 ν‘œμ‹œλŠ” 이 PR μš”μ•½λ§ŒμœΌλ‘œ 확인할 수 μ—†μŠ΅λ‹ˆλ‹€.

Possibly related PRs

  • Team-return/JOBIS-ANDROID-V2#557 β€” 두 PR λͺ¨λ‘ 지원 μš”μ²­ μ „ 파일 μ—…λ‘œλ“œ μ²˜λ¦¬μ™€ μ‹€νŒ¨ μ‹œ 제좜 μƒνƒœ 볡ꡬ 및 μ•ˆλ‚΄λ₯Ό λ‹€λ£Ήλ‹ˆλ‹€.

Suggested reviewers: tmdhoon2

Merge Risk: Minimal Β· up to d9c8e

This change shows why an application is unavailable and gives clearer guidance when an application or reapplication fails. Reviewers found no concrete defect in the supplied code. The one open question is whether the server returns 403 only for grade restrictions, and the PR states that it does.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed PR 제λͺ©μ€ 지원 및 μž¬μ§€μ› μ‹€νŒ¨ μ‹œ μƒνƒœ 였λ₯˜ 문ꡬλ₯Ό κ°œμ„ ν•œλ‹€λŠ” μ£Όμš” λ³€κ²½κ³Ό μΌμΉ˜ν•©λ‹ˆλ‹€. λ³€κ²½ μš”μ•½μ—λ„ ApplyFailure μ²˜λ¦¬μ™€ μž¬μ§€μ› μ‹€νŒ¨ μ•ˆλ‚΄ λ¬Έμžμ—΄ μΆ”κ°€κ°€ ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. λ‹€λ§Œ 제λͺ© μ•žλΆ€λΆ„μ˜ 이슈 λ²ˆν˜Έμ™€ 이λͺ¨μ§€ ν˜•μ‹μ€ κ°„κ²°μ„± κΈ°μ€€μ—μ„œ λ…Έμ΄μ¦ˆμ— ν•΄λ‹Ήν•©λ‹ˆλ‹€. 제λͺ© λ‚΄μš©μ€ changesetκ³Ό κ΄€λ ¨λ˜μ–΄ μžˆμœΌλ―€λ‘œ PASS둜 νŒμ •ν•©λ‹ˆλ‹€.
Description check Passed PR μ„€λͺ…은 μ €μž₯μ†Œ ν…œν”Œλ¦Ώμ˜ κ°œμš”, μž‘μ—… λ‚΄μš©, ν•  말 μ„Ήμ…˜μ„ λͺ¨λ‘ ν¬ν•¨ν•©λ‹ˆλ‹€. μž‘μ—… λ‚΄μš©μ—λŠ” unapplicable_reason νŒŒμ‹±, 403 ν•™λ…„ μ œν•œ 처리, 일반 μ‹€νŒ¨ μ‹œ 였λ₯˜ μ•ˆλ‚΄μ™€ 제좜 λ²„νŠΌ 볡ꡬ, 쀑볡 및 μ§„ν–‰ 쀑 지원 μ•ˆλ‚΄, 링크만 μ²¨λΆ€ν•œ 지원 ν—ˆμš©, 빈 URL μ œμ™Έκ°€ κΈ°μˆ λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. λ³€κ²½ μš”μ•½κ³Ό λŒ€μ²΄λ‘œ μΌμΉ˜ν•˜λ©° ν•„μˆ˜ 정보가 λŒ€λΆ€λΆ„ μ±„μ›Œμ Έ …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

PR μ„€λͺ…은 μ €μž₯μ†Œ ν…œν”Œλ¦Ώμ˜ κ°œμš”, μž‘μ—… λ‚΄μš©, ν•  말 μ„Ήμ…˜μ„ λͺ¨λ‘ ν¬ν•¨ν•©λ‹ˆλ‹€. μž‘μ—… λ‚΄μš©μ—λŠ” unapplicable_reason νŒŒμ‹±, 403 ν•™λ…„ μ œν•œ 처리, 일반 μ‹€νŒ¨ μ‹œ 였λ₯˜ μ•ˆλ‚΄μ™€ 제좜 λ²„νŠΌ 볡ꡬ, 쀑볡 및 μ§„ν–‰ 쀑 지원 μ•ˆλ‚΄, 링크만 μ²¨λΆ€ν•œ 지원 ν—ˆμš©, 빈 URL μ œμ™Έκ°€ κΈ°μˆ λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€. λ³€κ²½ μš”μ•½κ³Ό λŒ€μ²΄λ‘œ μΌμΉ˜ν•˜λ©° ν•„μˆ˜ 정보가 λŒ€λΆ€λΆ„ μ±„μ›Œμ Έ μžˆμŠ΅λ‹ˆλ‹€. λ‹€λ§Œ 이미지 첨뢀 μ—¬λΆ€λŠ” λͺ…μ‹œλ˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€. μ΄λŠ” ν•„μš”μ‹œ ν•­λͺ©μ΄λ―€λ‘œ μ€‘λŒ€ν•œ λˆ„λ½μ€ μ•„λ‹™λ‹ˆλ‹€.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix Β· Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

토끼가 링크λ₯Ό 골라 λ‹΄κ³ 
빈 μ£Όμ†ŒλŠ” μ‚΄λ©°μ‹œ λœμ–΄ λ‚΄λ„€
파일이 있으면 μ—…λ‘œλ“œν•˜κ³ 
μ‹€νŒ¨ ν† μŠ€νŠΈλ„ ꡬ뢄해 λ„μš°λ„€
λͺ¨μ§‘ ν™”λ©΄ μ‚¬μœ λ₯Ό 읽고
깑총, 제좜 흐름을 따라가넀

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 75893d4f-16b7-4559-8f14-f8d1a21e96a7
Commits

Reviewing files that changed from the base of the PR and between 295fb36 and d9c8ee6.

Files selected for processing: 7

  • core/domain/src/main/java/team/retum/usecase/entity/RecruitmentDetailsEntity.kt
  • core/network/src/main/java/team/retum/network/model/response/FetchRecruitmentDetailsResponse.kt
  • feature/application/src/main/java/team/retum/jobis/application/ui/ApplicationScreen.kt
  • feature/application/src/main/java/team/retum/jobis/application/viewmodel/ApplicationViewModel.kt
  • feature/application/src/main/res/values/strings.xml
  • feature/recruitment/src/main/java/team/retum/jobis/recruitment/ui/RecruitmentDetailsScreen.kt
  • feature/recruitment/src/main/java/team/retum/jobis/recruitment/viewmodel/RecruitmentDetailsViewModel.kt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ashxom
ashxom merged commit 8e21337 into develop Nov 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

버그 버그λ₯Ό μˆ˜μ •ν•©λ‹ˆλ‹€.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

지원 및 μž¬μ§€μ› μ‹€νŒ¨ μƒνƒœμ˜€λ₯˜ 문ꡬ κ°œμ„ 

1 participant