Skip to content

๐Ÿ”— :: (#561) ๋ฉด์ ‘ ์ ˆ์ฐจ ๊ธฐํƒ€ ๊ฐ’์— ๋Œ€ํ•œ ๊ณต๊ณ  ์ƒ์„ธ ํŒŒ์‹ฑ ์˜ˆ์™ธ ์ฒ˜๋ฆฌ - #562

Merged
ashxom merged 4 commits into
developfrom
bug/561-๋ฉด์ ‘-์ ˆ์ฐจ-๊ธฐํƒ€-๊ฐ’์—-๋Œ€ํ•œ-๊ณต๊ณ -์ƒ์„ธ-ํŒŒ์‹ฑ-์˜ˆ์™ธ-์ฒ˜๋ฆฌ
Nov 19, 2026

Hidden character warning

The head ref may contain hidden characters: "bug/561-\uba74\uc811-\uc808\ucc28-\uae30\ud0c0-\uac12\uc5d0-\ub300\ud55c-\uacf5\uace0-\uc0c1\uc138-\ud30c\uc2f1-\uc608\uc678-\ucc98\ub9ac"
Merged

ashxom merged 4 commits into
developfrom
bug/561-๋ฉด์ ‘-์ ˆ์ฐจ-๊ธฐํƒ€-๊ฐ’์—-๋Œ€ํ•œ-๊ณต๊ณ -์ƒ์„ธ-ํŒŒ์‹ฑ-์˜ˆ์™ธ-์ฒ˜๋ฆฌ

Conversation

@ashxom

@ashxom ashxom commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

๊ฐœ์š”

๋ฉด์ ‘ ์ ˆ์ฐจ์— ๊ธฐํƒ€ ๋˜๋Š” ๋ฏธ์ •์˜ ๊ฐ’์ด ํฌํ•จ๋˜์–ด๋„ ๊ณต๊ณ  ์ƒ์„ธ ํ™”๋ฉด์ด ํŒŒ์‹ฑ ์˜ค๋ฅ˜๋กœ ํ‘œ์‹œ๋˜์ง€ ์•Š๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

์ž‘์—… ๋‚ด์šฉ

  • HiringProgress์— ETC(๊ธฐํƒ€) ์ถ”๊ฐ€
  • ์•Œ ์ˆ˜ ์—†๋Š” ๋ฉด์ ‘ ์ ˆ์ฐจ ์‘๋‹ต์€ ETC๋กœ ์ฒ˜๋ฆฌํ•˜๋„๋ก Moshi ์–ด๋Œ‘ํ„ฐ ์ถ”๊ฐ€
  • ๋„คํŠธ์›Œํฌ Moshi ์„ค์ •์— ๋ฉด์ ‘ ์ ˆ์ฐจ ์–ด๋Œ‘ํ„ฐ ๋“ฑ๋ก

ํ•  ๋ง

์—†์Œ

Summary by CodeRabbit

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ
    • ์ฑ„์šฉ ์ง„ํ–‰ ์ƒํƒœ์— โ€˜๊ธฐํƒ€โ€™ ํ•ญ๋ชฉ์ด ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
    • ๊ธฐ์กด ํ•ญ๋ชฉ๊ณผ ์ผ์น˜ํ•˜์ง€ ์•Š๋Š” ์ง„ํ–‰ ์ƒํƒœ๋„ โ€˜๊ธฐํƒ€โ€™๋กœ ํ‘œ์‹œ๋˜์–ด, ์ƒˆ๋กœ์šด ์ƒํƒœ๊ฐ’์ด ํฌํ•จ๋œ ์ •๋ณด๋ฅผ ์•ˆ์ •์ ์œผ๋กœ ์ฒ˜๋ฆฌํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

@ashxom ashxom self-assigned this Nov 18, 2026
@ashxom
ashxom requested a review from a team as a code owner November 18, 2026 15:20
@ashxom ashxom added the ๋ฒ„๊ทธ ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค. label Nov 18, 2026
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change โ†’

No actionable comments were generated in the recent review.

Walkthrough

HiringProgress์— ETC ํ•ญ๋ชฉ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. HiringProgressAdapter๋Š” ๋ฌธ์ž์—ด์„ enum์œผ๋กœ ๋ณ€ํ™˜ํ•˜๊ณ , ์ผ์น˜ํ•˜๋Š” ํ•ญ๋ชฉ์ด ์—†์œผ๋ฉด ETC๋ฅผ ๋ฐ˜ํ™˜ํ•ฉ๋‹ˆ๋‹ค. ๋„คํŠธ์›Œํฌ ๋ชจ๋“ˆ์€ ์ด ์–ด๋Œ‘ํ„ฐ๋ฅผ Moshi์— ๋“ฑ๋กํ•ฉ๋‹ˆ๋‹ค.

Changes: ๋ฉด์ ‘ ์ง„ํ–‰ ๊ฐ’์˜ JSON ์ฒ˜๋ฆฌ

Layer / File(s) Summary
๊ธฐ๋ณธ enum ๊ฐ’ ์ถ”๊ฐ€
core/common/src/main/java/team/retum/common/enums/HiringProgress.kt
HiringProgress enum์— ํ™”๋ฉด ํ‘œ์‹œ๊ฐ’์ด "๊ธฐํƒ€"์ธ ETC๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
Moshi ๋ณ€ํ™˜ ๋ฐ ๋“ฑ๋ก
core/network/src/main/java/team/retum/network/adapter/HiringProgressAdapter.kt, core/network/src/main/java/team/retum/network/di/NetworkModule.kt
HiringProgressAdapter๊ฐ€ enum ์ด๋ฆ„๊ณผ ๋ฌธ์ž์—ด์„ ๋ณ€ํ™˜ํ•˜๊ณ , ์•Œ ์ˆ˜ ์—†๋Š” ๋ฌธ์ž์—ด์€ ETC๋กœ ์ฒ˜๋ฆฌํ•ฉ๋‹ˆ๋‹ค. NetworkModule์€ ์–ด๋Œ‘ํ„ฐ๋ฅผ Moshi์— ๋“ฑ๋กํ•˜๋ฉฐ KotlinJsonAdapterFactory ๋“ฑ๋ก์„ ์œ ์ง€ํ•ฉ๋‹ˆ๋‹ค.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related issues

Suggested reviewers: parkuiery, tmdhoon2

Merge Risk: Minimal ยท up to 60429

The change prevents the job posting detail screen from failing to parse when interview procedures contain unrecognized values. No concrete merge-blocking defect was established. Confirm that the server accepts "ETC" when a schedule is registered with the new "๊ธฐํƒ€" option.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed ์ œ๋ชฉ์€ ๋ฉด์ ‘ ์ ˆ์ฐจ์˜ ๊ธฐํƒ€ ๊ฐ’์œผ๋กœ ๋ฐœ์ƒํ•˜๋Š” ๊ณต๊ณ  ์ƒ์„ธ ํŒŒ์‹ฑ ์˜ค๋ฅ˜๋ฅผ ์ฒ˜๋ฆฌํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ๋ช…ํ™•ํžˆ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Description check Passed ์„ค๋ช…์— ํ…œํ”Œ๋ฆฟ์˜ ๊ฐœ์š”, ์ž‘์—… ๋‚ด์šฉ, ํ•  ๋ง ์„น์…˜์ด ๋ชจ๋‘ ์žˆ์Šต๋‹ˆ๋‹ค. ๋ณ€๊ฒฝ ๋ชฉ์ ๊ณผ ์ฃผ์š” ์ž‘์—…๋„ ๊ตฌ์ฒด์ ์œผ๋กœ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ํ† ๋ผ๊ฐ€ enum ์ˆฒ์„ ๋›ฐ์–ด๊ฐ€๋„ค
๋‚ฏ์„  ๊ฐ’๋„ ETC๋กœ ๋งž์ดํ•˜๋„ค
Moshi๊ฐ€ ๋ฌธ์ž์—ด์„ ๊ฑด๋„ค๋ฉด
์–ด๋Œ‘ํ„ฐ๊ฐ€ ์ด๋ฆ„์„ ์ฐพ์•„๋ณด๋„ค
๋ชป ์ฐพ์œผ๋ฉด โ€œ๊ธฐํƒ€โ€๋ผ ๋‹ตํ•˜๋„ค
๋‹น๊ทผ ์˜†์— JSON์ด ๊ณ ์š”ํ•˜๋„ค

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 03045f37-f7e4-47ae-8694-f8c3a961a639
Commits

Reviewing files that changed from the base of the PR and between 8e21337 and 604296a.

Files selected for processing: 3

  • core/common/src/main/java/team/retum/common/enums/HiringProgress.kt
  • core/network/src/main/java/team/retum/network/adapter/HiringProgressAdapter.kt
  • core/network/src/main/java/team/retum/network/di/NetworkModule.kt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ashxom
ashxom merged commit 1b8a205 into develop Nov 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๋ฒ„๊ทธ ๋ฒ„๊ทธ๋ฅผ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค.

Projects

None yet

1 participant