Repository navigation
Skip binary Ruby sources when scanning cache digest dependencies - #2751
Merged
joelhawksley merged 4 commits intoOct 27, 2026
Merged
joelhawksley merged 4 commits into
joelhawksley merged 4 commits into
Conversation
Some gems, like avo-advanced_search, load components from encrypted files. The component identifier then points at a binary file, and scanning it for render calls raised invalid byte sequence errors at boot. Those files are still hashed into the digest, so changing them still busts the cache.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some gems, like avo-advanced_search, load components from encrypted files. The component identifier then points at a binary file, and scanning it for render calls raised invalid byte sequence errors at boot. Those files are still hashed into the digest, so changing them still busts the cache.
What are you trying to accomplish?
Avoid blowing up if a project has dependencies with binary components
What approach did you choose and why?
Just check the encoding instead of trying to guess around extensions etc. We are already reading to checking if encoding is valid should be cheap.
Anything you want to highlight for special attention from reviewers?
Nothing comes to mind =)