Skip to content

docs: each operator creates their own Google file and keys - #67

Merged
rparundekar merged 3 commits into
mainfrom
docs/own-google-connection-file
Nov 4, 2026
Merged

rparundekar merged 3 commits into
mainfrom
docs/own-google-connection-file

Conversation

@rparundekar

Copy link
Copy Markdown
Collaborator

What changed

  • README step 3: each operator creates their own Google connection file. An Internal client only works inside one organization, so a shared file fails across organizations.
  • README step 5: the operator asks an admin only for access (Drive, Slack app collaborator, Luma calendar admin), then generates their own Slack token and Luma key.
  • MAINTAINING.md: first-time setup now covers only the Slack app and the Luma calendar. Adding the next person and Removing a person match the new flow.
  • aaif-check-setup: its fixes point at those steps instead of asking an admin for a file or key.

This replaces the one-shared-token decision in #66. A Slack user token acts as whoever generated it, so a shared one let its holder search that person's DMs and post as them.

Testing

  • test_check_setup.py, library tests and pre-commit pass.
  • Not tested: the collaborator route for getting a token. Slack's docs confirm a user token belongs to the user who authorizes, but I found no page confirming that a collaborator can get their own token from the app settings page. Confirm this with a real collaborator before merging. If it fails, each operator can create their own app from the manifest.

🤖 Generated with Claude Code

…keys

An Internal Google client only works inside one organization, so a shared
connection file fails for operators in different organizations. A Slack user
token acts as whoever generated it, so sharing one let its holder search that
person's DMs and post as them.

README step 3 now creates the connection file, and step 5 asks an admin only for
access: Drive, Slack app collaborator and Luma calendar admin. The operator then
generates both keys. aaif-check-setup points at those steps.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rparundekar

Copy link
Copy Markdown
Collaborator Author

Self-Review

Important (5)

  • [code-reviewer] README.md step 4: signing in before step 5 grants access gives a "cannot open the Community Intake sheet" line, and its fix sends the reader back to signing in.
  • [code-reviewer] README.md troubleshooting: the "Access blocked" fix only works for External. On Internal it usually means the wrong account.
  • [security, code-reviewer] MAINTAINING.md, Removing a person: "revoke their token" names no route, and an admin doesn't hold that token.
  • [security] MAINTAINING.md: nothing retires a token or key someone received under the shared model from docs: split setup into first-time and next-person, drop the helper #66.
  • [code-reviewer] check_setup.py and README.md: "replace the saved one" has no instructions, and a second Keychain item with the same name is ambiguous.

Suggestions (6)

  • [code-reviewer] check_setup.py: the API-off line says "AAIF's Google connection", but the project is now the operator's own.
  • [code-reviewer] SKILL.md: "relay the Keychain Access steps" can skip creating the key.
  • [code-reviewer] test_check_setup.py: the step 5 heading and the new fix pointers aren't pinned.
  • [code-reviewer] MAINTAINING.md: "once per organization" is stale, and "It is a user token" now reads as the app.
  • [code-reviewer] README.md: accessNotConfigured appears in the setup check, not on the sign-in screen.
  • [security] README.md: the token warning doesn't mention DMs, and step 4 no longer warns against a file someone else sends.

Strengths

  • check_setup.py changes are message text only, and no secret reaches any output.
  • No real personal data or token values in the diff.
  • Step and part references in the docs and the check all resolve correctly.

Generated using wayfare.

rparundekar and others added 2 commits November 3, 2026 22:41
- Step 4 and the setup check say a missing-access line is expected until step 5
- Access blocked covers Internal and External separately
- Removing a person names how to end a token only they hold, and covers any
  token or key that was passed around
- Step 5 explains replacing a saved key
- Tests pin step 5 and the new fix pointers

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Adding and removing a person cover private organizer rooms and the Ops staff
  roster, because a personal token only sees rooms its owner is in
- The setup skill says when not to run the printed sign-in command
- README names the disabled-service line the check actually prints

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rparundekar

Copy link
Copy Markdown
Collaborator Author

Self-Review: Improvements

Important (7 / 7 fixed):

  • README.md step 4: missing-access line. Fixed: step 4 and the check's fix say it's expected until step 5, and SKILL.md says when not to run the printed sign-in command.
  • README.md: Access blocked. Fixed: separate advice for Internal and External.
  • MAINTAINING.md: revoking a token only its owner holds. Fixed: names the three routes, including revoking all tokens.
  • MAINTAINING.md: tokens or keys passed around earlier. Fixed: the removal steps now cover them.
  • README.md: replacing a saved key. Fixed: edit the existing Keychain item, and both messages point there.
  • MAINTAINING.md, README.md: a personal token can't see private organizer rooms its owner isn't in. Fixed: the add and remove steps cover the rooms and the Ops staff roster, and the README warns against approving creates.
  • SKILL.md: the assistant could run the printed sign-in command during the expected no-access state. Fixed: new entry for that line.

Suggestions (7 / 7 addressed, 1 partly):

  • API-off wording, SKILL.md create step, step 5 test pins, stale MAINTAINING.md framing, the service-off line in the README, and the token and file warnings are fixed.
  • App name in README.md. Skipped: awaiting the maintainer's confirmation of the real name.

Skipped:

  • Moving the access request ahead of step 4. The maintainer asked for step 3 to be creating the file, so the wording handles the order instead.

Not tested: the Slack collaborator route for a personal token, and the Slack, Luma and Google console screens. These need one live pass with a second account.

Commits: 5c829e6, ea3cb79


Generated using wayfare.

@rparundekar
rparundekar marked this pull request as ready for review November 4, 2026 06:47
@rparundekar
rparundekar merged commit 2d5ce99 into main Nov 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant