Repository navigation
fix(sync): stop the report calling pending work in sync - #68
Merged
Merged
Conversation
- A step that exits 0 while its own findings list warn or bad items now reads DRIFT. Invite, directory and clean all said "in sync" with work pending. - Invite counts people: one organizer in two passes was counted twice, so 31 read as 61. Room additions get their own count. - A person whose Slack ID column disagrees with the live lookup is held, not invited. They have two accounts, and an invite could add a second copy. - The identity step runs with --suggest, so people on another address show up as name matches. Invite's advice points there first. - CRM rows missing from the intake no longer read as probable test data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Split DRIFT from a new "needs review" outcome. Findings a --write would apply are DRIFT. Findings no write clears are needs review, which leaves the exit code at 0 and never points anyone at a write. - Hold a Slack ID conflict only when the column's account is live. A stale id no longer blocks an invite. - A second address cannot invite a held person. - Count no-account and already-in people correctly across passes. - A malformed findings file no longer crashes run_step. - Word the advice so a name match is not treated as proof, and fix stale text. - Docs and tests cover the new outcome and the run_step wiring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Self-Review: ImprovementsTwo agents ran (the 50-300 line tier): code-reviewer and security. Security found nothing exploitable. Important (3 / 3 fixed):
Suggestions (6 / 6 fixed):
The fixes were checked by the test scripts and pre-commit. The agents did not re-review this commit. Generated using wayfare. |
The stale-id case leaves a stranger in the room, which loads the Slack config from the sheet. It passed locally only because gws is installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
An independent review of the follow-up commits reproduced these: - Reviewed rows that disagree with each other skipped the hold, so a second account could be invited. They are now conflicts against the live answer. - A hit on a deactivated account beat a correct live column id and stranded the person. It now counts as a miss, and is never invited. - A wrong cell silently dropped a different organizer. Everyone held is now named in the log and on the page, and an account is exempt from the strangers list only for someone on that room's roster. - `--write` anywhere in an action read as DRIFT, so identity's name matches would exit 2 every night. Only the prefixes in APPLY_ACTIONS count now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A third row naming the one live account was dropped, so the invite hold could be skipped when the first two ids were dead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sync report said "in sync" on steps with work pending, and some of its counts were wrong. Reading the 2026-11-03 report showed:
Fix
sync.py: an exit 0 whose findings start withapply with --writeorre-run --writereads DRIFT. Any other open finding reads the newneeds review, which leaves the exit code alone. A run that wrote stays WROTE, and PARTIAL still wins.invite_organizers.py: counts people, with room additions as a separate tile. Anyone with two live accounts, or with reviewed rows that disagree, is held and not invited. Everyone held is named in the log and on the page. A column id that is no live account is treated as stale, and a deactivated lookup hit gives way to a live column id.sync.py: identity runs with--suggest. Suggestions are never written automatically.sync_crm.py: new wording for rows on the CRM but not the intake.Known limit
A person with no usable lookup hit whose reviewed rows disagree stays "no Slack account", with a warning in the log. They aren't invited, so it can't cause a wrong invite. Two different held people with the same name show as one in the held count and list; neither is invited.
Verification
test_sync.py,test_invite_organizers.pyandtest_resolve_slack_ids.py. The affected skill suites and the library tests pass withgwsoff the PATH, and pre-commit is clean.🤖 Generated with Claude Code
Generated using wayfare.