Repository navigation
feat(chapters): raise the chapter cap from 100 to 125 - #69
Open
rparundekar wants to merge 2 commits into
Open
rparundekar wants to merge 2 commits into
rparundekar wants to merge 2 commits into
Conversation
The estate reached 100 live chapters with two cities (Columbus, Philadelphia) holding Accepted organizers and no chapter. The operator chose to raise the ceiling rather than retire a chapter. Prose no longer restates the number, so the next change is one line; the cap tests compute their expectations from CHAPTER_CAP. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- rewrap the cap comment and reference paragraph to the file's width - use the CAP alias throughout the incoming-count checks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Self-ReviewThe diff is 46 lines with no auth, secrets or workflow content, so I reviewed it inline without agents. That includes the security pass. Suggestions (2)
Strengths
Generated using wayfare. |
Collaborator
Author
Self-Review: ImprovementsSuggestions (2 / 2 fixed):
Commits: 16f798a Generated using wayfare. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Chapters List reached 100 live chapters, which is the cap. Two cities have Accepted organizers and no chapter yet: Columbus and Philadelphia. Both the Drive-folder guard in
create_chapter.pyand the feed-row guard insync_chapters.pyrefused them. The decision was to raise the cap to 125 rather than retire an existing chapter.What
CHAPTER_CAPgoes from 100 to 125. The comment records when it was set and when it was raised.test_chapter_cap.pycomputes its expected values fromCHAPTER_CAPinstead of hard-coding 98, 100 and 101.aaif-sync-chaptersdescription:still says "100-chapter cap". Editing a description needs an eval run first (seeevals/README.md), and that wording is only a trigger phrase.Checks
test_chapter_cap,test_chapter_health,test_sync_chapters,test_create_chapter,test_syncand pre-commit on the changed files all pass.🤖 Generated with Claude Code