Skip to content

feat(chapters): raise the chapter cap from 100 to 125 - #69

Open
rparundekar wants to merge 2 commits into
mainfrom
chore/chapter-cap-125
Open

rparundekar wants to merge 2 commits into
mainfrom
chore/chapter-cap-125

Conversation

@rparundekar

Copy link
Copy Markdown
Collaborator

Why

The Chapters List reached 100 live chapters, which is the cap. Two cities have Accepted organizers and no chapter yet: Columbus and Philadelphia. Both the Drive-folder guard in create_chapter.py and the feed-row guard in sync_chapters.py refused them. The decision was to raise the cap to 125 rather than retire an existing chapter.

What

  • CHAPTER_CAP goes from 100 to 125. The comment records when it was set and when it was raised.
  • test_chapter_cap.py computes its expected values from CHAPTER_CAP instead of hard-coding 98, 100 and 101.
  • Prose says "the chapter cap" instead of "100-chapter cap", and "one short of the cap" instead of "99", so the next change is one line.
  • Left alone: the aaif-sync-chapters description: still says "100-chapter cap". Editing a description needs an eval run first (see evals/README.md), and that wording is only a trigger phrase.

Checks

test_chapter_cap, test_chapter_health, test_sync_chapters, test_create_chapter, test_sync and pre-commit on the changed files all pass.

🤖 Generated with Claude Code

rparundekar and others added 2 commits November 12, 2026 12:18
The estate reached 100 live chapters with two cities (Columbus,
Philadelphia) holding Accepted organizers and no chapter. The operator
chose to raise the ceiling rather than retire a chapter.

Prose no longer restates the number, so the next change is one line;
the cap tests compute their expectations from CHAPTER_CAP.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- rewrap the cap comment and reference paragraph to the file's width
- use the CAP alias throughout the incoming-count checks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rparundekar

Copy link
Copy Markdown
Collaborator Author

Self-Review

The diff is 46 lines with no auth, secrets or workflow content, so I reviewed it inline without agents. That includes the security pass.

Suggestions (2)

  • [inline] skills/aaif-sync-chapters/references/chapter-cap.md:35 and skills/aaif-sync-chapters/scripts/sync_chapters.py:109: the edited lines run past the wrap width the rest of each file keeps.
  • [inline] skills/aaif-sync-chapters/scripts/test_chapter_cap.py:95: one check still spells sc.CHAPTER_CAP right next to the new CAP alias.

Strengths

  • The cap is still defined once, and create_chapter imports it, so the folder guard and the row guard move together.
  • The cap tests no longer hard-code 98, 100 or 101, so the next change to the number is one line.
  • Security: nothing to report. It changes a constant and some prose, with no input, secret or PII.

Generated using wayfare.

@rparundekar

Copy link
Copy Markdown
Collaborator Author

Self-Review: Improvements

Suggestions (2 / 2 fixed):

  • skills/aaif-sync-chapters/references/chapter-cap.md:35, sync_chapters.py:109: lines past the wrap width. Fixed: rewrapped both.
  • skills/aaif-sync-chapters/scripts/test_chapter_cap.py:95: mixed sc.CHAPTER_CAP and CAP. Fixed: it uses CAP throughout now.

Commits: 16f798a


Generated using wayfare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant